Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes should warn when referenced imagePullSecret does not exist #88142

Open
mrueg opened this issue Feb 14, 2020 · 2 comments
Open

Kubernetes should warn when referenced imagePullSecret does not exist #88142

mrueg opened this issue Feb 14, 2020 · 2 comments

Comments

@mrueg
Copy link
Contributor

@mrueg mrueg commented Feb 14, 2020

What would you like to be added:
A warning (or even error) should be emitted, when a scheduled workload references a non-existing imagePullSecret.
Why is this needed:
An imagePullSecret is necessary for running images from private registry. They are often referenced in the Pod, parent object (e.g. deployment) or ServiceAccount. They might not need to exist yet, when the parent object or serviceaccount gets created, but they need to when the Pod gets scheduled in order to pull the image. It is a bad user experience if the imagePullSecret that is referenced has a typo in the referenced secret's name or the referenced secret does not exist. As far as I can see there are no warnings emitted for this case.

@neolit123

This comment has been minimized.

Copy link
Member

@neolit123 neolit123 commented Feb 16, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Feb 16, 2020
@marquiz

This comment has been minimized.

Copy link

@marquiz marquiz commented Feb 19, 2020

Perhaps a warning event should be created? I'm not sure if an error would be the right thing to do as the image pull might succeed without the secret in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.