Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing default for kube-proxy healthz bind address #88443

Closed
sftim opened this issue Feb 23, 2020 · 5 comments · Fixed by #88512
Closed

Fix confusing default for kube-proxy healthz bind address #88443

sftim opened this issue Feb 23, 2020 · 5 comments · Fixed by #88512
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/unresolved Indicates an issue that can not or will not be resolved.

Comments

@sftim
Copy link
Contributor

sftim commented Feb 23, 2020

What would you like to be amended:
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-proxy/ lists:

--healthz-bind-address 0.0.0.0 Default: 0.0.0.0:10256

The IP address for the health check server to serve on (set to 0.0.0.0 for all IPv4 interfaces and :: for all IPv6 interfaces)

I'd like the default for that command line option to actually be 0.0.0.0, so that the documentation looks right. Internally, the behavior (listen on 0.0.0.0:10256 unless --healthz-bind-address sets a different bind address) should stay the same even if the implementation is updated.

Why is this needed:
This was originally reported as a website defect (and proposed fix): kubernetes/website#19213

/kind cleanup
/sig network
/sig docs
/priority backlog

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 23, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/docs Categorizes an issue or PR as relevant to SIG Docs. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 23, 2020
@sftim
Copy link
Contributor Author

sftim commented Feb 24, 2020

/remove-kind feature

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2020
@athenabot
Copy link

/triage unresolved

Comment /remove-triage unresolved when the issue is assessed and confirmed.

🤖 I am a bot run by vllry. 👩‍🔬

@k8s-ci-robot k8s-ci-robot added the triage/unresolved Indicates an issue that can not or will not be resolved. label Feb 24, 2020
@jsoref
Copy link
Contributor

jsoref commented Feb 24, 2020

--metrics-bind-address should be changed as well

@SataQiu
Copy link
Member

SataQiu commented Feb 24, 2020

According to

  1. https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/apis/config/types.go#L117-L122
// healthzBindAddress is the IP address and port for the health check server to serve on,
// defaulting to 0.0.0.0:10256
HealthzBindAddress string
// metricsBindAddress is the IP address and port for the metrics server to serve on,
// defaulting to 127.0.0.1:10249 (set to 0.0.0.0 for all interfaces)
MetricsBindAddress string
  1. https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server.go#L125-L135
// The fields below here are placeholders for flags that can't be directly mapped into
// config.KubeProxyConfiguration.
//
// TODO remove these fields once the deprecated flags are removed.

// master is used to override the kubeconfig's URL to the apiserver.
master string
// healthzPort is the port to be used by the healthz server.
healthzPort int32
// metricsPort is the port to be used by the metrics server.
metricsPort int32

@aojea @thockin
Maybe we should deprecate --healthz-port and --metrics-port firstly.
If this is the right direction, I am willing to send a PR for this :-)

@aojea
Copy link
Member

aojea commented Feb 24, 2020

🤔 it seems that those flags that allow to specify the ports were added "recently" (1.14)
#72682

I think that @thockin is the best person to define the strategy regarding configuration flags, config file, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/unresolved Indicates an issue that can not or will not be resolved.
Projects
None yet
6 participants