Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize prepulling all images in `e2e_node` tests #89443

Open
mattjmcnaughton opened this issue Mar 24, 2020 · 4 comments
Open

Parallelize prepulling all images in `e2e_node` tests #89443

mattjmcnaughton opened this issue Mar 24, 2020 · 4 comments

Comments

@mattjmcnaughton
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton commented Mar 24, 2020

What would you like to be added:
Unless disabled, the test/e2e_node tests will prepull all images when running. They do so using the PrePullAllImages function.

I think there's the opportunity to improve the runtime of the test suite by prepulling the images in parallel.

Why is this needed:
Its always nicer to have faster tests :) Specifically for users running make test-e2e-node locally, it's nice to have the image prepull occur as quick as possible.

That being said, we should also be cognizant of any tradeoffs associated with prepulling the images in parallel. If the code is substantially more complex, we would need a large improvement in test speed to justify it. I'm hopeful this discussion could be had once we have a proof of concept diff (which I think should be fairly minimal effort to create).

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

@mattjmcnaughton mattjmcnaughton commented Mar 24, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Mar 24, 2020
@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

@mattjmcnaughton mattjmcnaughton commented Mar 24, 2020

I think this could be a good first issue for someone looking to get involved with contributing to sig-node :) Please post if you plan on working on it, so that there aren't multiple people tackling it.

@sam-gaylert

This comment has been minimized.

Copy link

@sam-gaylert sam-gaylert commented Mar 24, 2020

I'd be interested! I'm looking for a first issue and think this would be a good one

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

@mattjmcnaughton mattjmcnaughton commented Mar 24, 2020

Wonderful! Want to reach out to me on Kubernetes slack? https://slack.k8s.io/

I'm @mattjmcnaughton on there too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.