Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random SHA being used for github.com/storageos/go-api #89497

Open
dims opened this issue Mar 25, 2020 · 1 comment
Open

Random SHA being used for github.com/storageos/go-api #89497

dims opened this issue Mar 25, 2020 · 1 comment

Comments

@dims
Copy link
Member

@dims dims commented Mar 25, 2020

@croomes in kubernetes go.mod file, we are using a SHA (see snippet below). The closest tag seems to be 1.0.0-rc1 which seems to be a couple of commits behind storageos/go-api@1.0.0-rc1...343b3ef

Can you please tag 343b3eff91fc with a proper semver version say v1.0.0 So we could then use that in our go.mod? Looks like you already have gotten started with a v2 API looking at recent traffic https://github.com/storageos/go-api/commits/master

dims@dims-a01:~/go/src/k8s.io/kubernetes$ rg github.com/storageos/go-api go.mod
96:	github.com/storageos/go-api v0.0.0-20180912212459-343b3eff91fc
441:	github.com/storageos/go-api => github.com/storageos/go-api v0.0.0-20180912212459-343b3eff91fc
@dims dims added the kind/bug label Mar 25, 2020
@dims

This comment has been minimized.

Copy link
Member Author

@dims dims commented Mar 25, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Mar 25, 2020
@liggitt liggitt added kind/cleanup and removed kind/bug labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.