Skip to content

Update test/integration to use the term "Control Plane" #94900

@spiffxp

Description

@spiffxp

There are a number of tests that can probably updated to refer to a "control plane" or a "primary" instead of a "master".

Some of these updates can be done outright (variable names, comments), while others may require more refactoring.

It would probably be a good idea to start with the test/integration/framework package, and work outwards from there.

framework/master_utils.go
102:func (h *MasterHolder) SetMaster(m *controlplane.Master) {
127:func startMasterOrDie(masterConfig *controlplane.Config, incomingServer *httptest.Server, masterReceiver MasterReceiver) (*controlplane.Master, *httptest.Server, CloseFunc) {
252:func NewIntegrationTestMasterConfig() *controlplane.Config {
258:func NewIntegrationTestMasterConfigWithOptions(opts *MasterConfigOptions) *controlplane.Config {
285:func NewMasterConfig() *controlplane.Config {
290:func NewMasterConfigWithOptions(opts *MasterConfigOptions) *controlplane.Config {
332:// CloseFunc can be called to cleanup the master
336:func RunAMaster(masterConfig *controlplane.Config) (*controlplane.Master, *httptest.Server, CloseFunc) {
345:func RunAMasterUsingServer(masterConfig *controlplane.Config, s *httptest.Server, masterReceiver MasterReceiver) (*controlplane.Master, *httptest.Server, CloseFunc) {

Full list of files in test/integration that may be affected

$ ag -l master | sort
BUILD
apimachinery/watch_restart_test.go
apimachinery/watch_timeout_test.go
apiserver/admissionwebhook/admission_test.go
apiserver/admissionwebhook/client_auth_test.go
apiserver/admissionwebhook/load_balance_test.go
apiserver/admissionwebhook/reinvocation_test.go
apiserver/admissionwebhook/timeout_test.go
apiserver/apiserver_test.go
apiserver/apply/apply_test.go
apiserver/certreload/certreload_test.go
apiserver/flowcontrol/concurrency_test.go
auth/accessreview_test.go
auth/auth_test.go
auth/bootstraptoken_test.go
auth/node_test.go
auth/rbac_test.go
auth/svcaccttoken_test.go
certificates/admission_subjectrestriction_test.go
certificates/defaulting_test.go
certificates/field_selector_test.go
client/cert_rotation_test.go
configmap/configmap_test.go
cronjob/cronjob_test.go
daemonset/daemonset_test.go
defaulttolerationseconds/defaulttolerationseconds_test.go
deployment/util.go
endpoints/endpoints_test.go
endpointslice/endpointslicemirroring_test.go
etcd/crd_overlap_storage_test.go
etcd/etcd_cross_group_test.go
etcd/etcd_storage_path_test.go
etcd/server.go
evictions/evictions_test.go
framework/BUILD
framework/master_utils.go
ipamperf/README.md
ipamperf/ipam_test.go
master/BUILD
master/audit_test.go
master/crd_test.go
master/graceful_shutdown_test.go
master/kms_transformation_test.go
master/kube_apiserver_test.go
master/main_test.go
master/secrets_transformation_test.go
master/synthetic_master_test.go
master/transformation_testcase.go
metrics/metrics_test.go
namespace/ns_conditions_test.go
node/lifecycle_test.go
objectmeta/objectmeta_test.go
openshift/openshift_test.go
pods/pods_test.go
quota/quota_test.go
replicaset/replicaset_test.go
replicationcontroller/replicationcontroller_test.go
scheduler/extender_test.go
scheduler/framework_test.go
scheduler/preemption_test.go
scheduler/priorities_test.go
scheduler/scheduler_test.go
scheduler/taint_test.go
scheduler/util.go
scheduler_perf/util.go
secrets/secrets_test.go
serviceaccount/service_account_test.go
statefulset/util.go
storageclasses/storage_classes_test.go
ttlcontroller/ttlcontroller_test.go
util/util.go
utils.go
volume/attach_detach_test.go
volume/persistent_volumes_test.go
volumescheduling/util.go
volumescheduling/volume_binding_test.go

/kind cleanup
/wg naming

/sig api-machinery
/sig auth
/sig apps
/sig network
/sig node
/sig storage
/sig testing

Guessed sigs based on names of dirs that contain references to the old term

Metadata

Metadata

Labels

area/testkind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.sig/appsCategorizes an issue or PR as relevant to SIG Apps.sig/authCategorizes an issue or PR as relevant to SIG Auth.sig/networkCategorizes an issue or PR as relevant to SIG Network.sig/nodeCategorizes an issue or PR as relevant to SIG Node.sig/storageCategorizes an issue or PR as relevant to SIG Storage.sig/testingCategorizes an issue or PR as relevant to SIG Testing.wg/namingCategorizes an issue or PR as relevant to WG Naming.

Type

No type

Projects

Status

Closed / Done

Status

Triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions