Remove WindowsGMSA and WindowsRunAsUserName feature gates in 1.20

[marosset]

Both WindowsGMSA and WindowsRunAsUserName feature gates have been GA since v1.18 and were scheduled to be removed in v1.20.

kubernetes/pkg/features/kube_features.go

Lines 714 to 715 in 2046f42

	WindowsGMSA: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20
	WindowsRunAsUserName: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20

/sig windows
/milestone v1.20
/good-first-issue

[k8s-ci-robot]

@marosset:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Both WindowsGMSA and WindowsRunAsUserName feature gates have been GA since v1.18 and were scheduled to be removed in v1.20.

kubernetes/pkg/features/kube_features.go

Lines 714 to 715 in 2046f42

	WindowsGMSA: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20
	WindowsRunAsUserName: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20

/sig windows
/milestone v1.20
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marosset]

/triage accepted

[mrmassis]

Hi,
how can i help with that?

[wawa0210]

Hi,
how can i help with that?
Delete the codes related to these two feature gates, because they have been GA and are enabled by default

[marosset]

Yup, @mrmassis feel free to assign the issue to yourselft and then remove the features gates from the file listed above and any other places they are used in code.

Thanks!

[Ravi19967]

Hey, can i take this up ?

[Ravi19967]

/assign

[wawa0210]

Hey, can i take this up ?

It seems that @mrmassis proposed it first. You can communicate with him before you start.

[Ravi19967]

ok sure

[mrmassis]

/assign

[mrmassis]

Hi,
Sorry by delay, but i cant push the issue branch and receive:
fatal: unable to access 'https://github.com/kubernetes/kubernetes.git/': The requested URL returned error: 403

I already fill the form to contriburter. Any sugestion?
Regards

[wawa0210]

Before you start, you can read https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md

[mrmassis]

i already assing to CLA and make a new branch issue-95707. But when i push the branch my permission is denny.
any tips?
Tkz

[marosset]

@mrmassis Try forking the kubernetes/kubernetes repository and then creating the pull request from a branch in your personal github repository.

[mrmassis]

Tkz,
I create a PR, but i received:
cla/linuxfoundation — commit missing GitHub user

but i already do it. Whats is wrong?

[mrmassis]

Ok, i found the error. My name in git was wrong. Sorry, Im waiting the result for PR.
Tkz

[mrmassis]

Now, i waiting for

Some checks haven’t completed yet
pull-kubernetes-bazel-build Expected — Waiting for status to be reported                                      Required
pull-kubernetes-bazel-test Expected — Waiting for status to be reported                                        Required
pull-kubernetes-conformance-kind-ga-only-parallel Expected — Waiting for status to be reported Required
pull-kubernetes-dependencies Expected — Waiting for status to be reported                                 Required
pull-kubernetes-e2e-gce-100-performance Expected — Waiting for status to be reported              Required
pull-kubernetes-e2e-gce-ubuntu-containerd Expected — Waiting for status to be reported             Required
pull-kubernetes-e2e-kind Expected — Waiting for status to be reported                                          Required
pull-kubernetes-e2e-kind-ipv6 Expected — Waiting for status to be reported                                  Required
pull-kubernetes-integration Expected — Waiting for status to be reported                                       Required
pull-kubernetes-node-e2e Expected — Waiting for status to be reported                                         Required
pull-kubernetes-typecheck Expected — Waiting for status to be reported                                        Required
pull-kubernetes-verify Expected — Waiting for status to be reported                                               Required
@k8s-ci-robot
tide Pending — Not mergeable. Needs approved, lgtm labels.

[mrmassis]

Hi everyone,
Is normal waiting this itens, or I must provide then?
Tkz

[mrmassis]

Ok, Em ter., 20 de out. de 2020 às 15:47, Mark Rossetti < notifications@github.com> escreveu:

…

@mrmassis <https://github.com/mrmassis> Try forking the kubernetes/kubernetes repository and then creating the pull request from a branch in your personal github repository. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#95707 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYOZ5KYRTXSRTHFWEV4GBTSLXLK5ANCNFSM4SWL3LDA> .

-- Marcio Roberto Miranda Assis Doutor em Ciência da Computação na UNICAMP

[wawa0210]

When your code is ready, you can pull a pr from your own repo to kubernetes' repo~~ Remember to read the connection I posted earlier and the sub-connections inside.

#95707 (comment)

[palnabarun]

Hi 👋🏽, we already past the code freeze for v1.20 and the release is due next week. At this point in time, we are considering only changes which are release blocking. Hence, I am removing this from the v1.20 milestone.

Please feel to ping us on #sig-release if you feel otherwise.

/milestone clear

[Aut0R3V]

Hey
Is there anything that can be done here?

[coderfornow]

Hi @mrmassis !
can I take this? anything required?

[mrmassis]

Hi, yes of course. Nothing to relate. Em ter., 19 de jan. de 2021 às 13:24, coderfornow <notifications@github.com> escreveu:

…

Hi @mrmassis <https://github.com/mrmassis> ! can I take this? anything required? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#95707 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYOZ5NSDJSMMHWIPAHLXPLS2WW2NANCNFSM4SWL3LDA> .

-- Marcio Roberto Miranda Assis Doutor em Ciência da Computação na UNICAMP

[coderfornow]

/assign