Add container exit error code between ADD and ContainerDied

[karan]

What would you like to be added:

Between

SyncLoop (ADD, "api")

and

SyncLoop (PLEG): "foo(96eb6e9d-84cf-12ea-b64a-42010a80005d)", event: &pleg.PodLifecycleEvent{ID:"96eb6e9d-84cf-12ea-b64a-42010a80005d", Type:"ContainerStarted", Data:"bar"}

and

SyncLoop (PLEG): "foo(96eb6e9d-84cf-12ea-b64a-42010a80005d)", event: &pleg.PodLifecycleEvent{ID:"96eb6e9d-84cf-12ea-b64a-42010a80005d", Type:"ContainerDied", Data:"bar"}

We can't tell if container died with a status error (we can by looking at containerd logs though).

Why is this needed:

It would make debugging dying containers much easier.

[k8s-ci-robot]

@karan: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karan]

/sig node

[AkashSarda]

/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[SergeyKanzhelev]

/cc

[adisky]

/remove-lifecycle stale
/assign

[adisky]

@karan I am new to kubelet code, trying to understand.
IIUC, PLEG does not passes exitCode in the generated events, one way is to pass the exit code in events generated.

kubernetes/pkg/kubelet/pleg/generic.go

Lines 223 to 224 in bce5d7a

	for _, container := range allContainers {
	events := computeEvents(oldPod, pod, &container.ID)

other way is to get the exit code from podCache before logging which return pod status.

kubernetes/pkg/kubelet/kubelet.go

Lines 1958 to 1961 in bce5d7a

	if pod, ok := kl.podManager.GetPodByUID(e.ID); ok {
	klog.V(2).Infof("SyncLoop (PLEG): %q, event: %#v", format.Pod(pod), e)
	handler.HandlePodSyncs([]*v1.Pod{pod})
	} else {

[Dragoncell]

/assign

[adisky]

closing this issue, as It has been fixed by #99880
/close

[k8s-ci-robot]

@adisky: Closing this issue.

In response to this:

closing this issue, as It has been fixed by #99880
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.