Updates deps in order to remove rsc.io/sampler #97337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/apiserver
area/cloudprovider
area/dependency
|
/remove-sig instrumentation |
k8s-ci-robot
removed
the
sig/instrumentation
k8s-ci-robot
added
size/S
dlorenc
changed the title
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm /assign @cheftako for approval. |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
No code changes in vendor? |
Nope! For reasons I still don't completely understand, go modules can get resolved and end up as part of the go.mod file even if they are never compiled into the final binaries. This issue is the closest to an explanation I've found: golang/go#27900 So, this change should not have any actual effect. I think it's still a good practice to keep these type of things cleaned up and out of the go.mod files where possible to make future updates easier, though. |
|
/test all |
BenTheElder
approved these changes
Dec 18, 2020
k8s-ci-robot
removed
the
lgtm
I noticed rsc.io/sampler was in here, which didn't make any sense. It appears to have been mistakenly included in a transitive dependency at some point. This PR attempts to fix that by updating the intermediate deps far enough to stop requiring the rsc.io packages.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @liggitt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cheftako, dlorenc, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dlorenc
pushed a commit
to dlorenc/kubernetes
that referenced
this pull request
Jun 16, 2021
This re-removes rsc.io/quote and rsc.io/sampler from the go.mod. They never made it into the vendor/ tree, but still contribute to dependency resolution complexity. These were originally removed in kubernetes#97337 but slipped back in. Signed-off-by: Dan Lorenc <dlorenc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I noticed rsc.io/sampler was in here, which didn't make any sense.
It appears to have been mistakenly included in a transitive dependency
at some point.
This PR attempts to fix that by updating the intermediate deps far enough
to stop requiring the rsc.io packages.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: