Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Azure file share not deleted issue when the namespace is deleted #97417

Merged
merged 1 commit into from Dec 21, 2020
Merged

fix Azure file share not deleted issue when the namespace is deleted #97417

merged 1 commit into from Dec 21, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 21, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix Azure file share not deleted issue when the namespace is deleted
default namespace should always be default

PV deletion error when PVC is created in a namespace, e.g. test

status:
  message: 'Failed to create deleter for volume "pvc-353f3a5c-640f-48c8-add7-a7f7fb13025a":
    Couldn''t get secret test/azure-storage-account-andyblobtest-secret'
  phase: Failed
# k get pv pvc-353f3a5c-640f-48c8-add7-a7f7fb13025a
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                STORAGECLASS   REASON   AGE
pvc-353f3a5c-640f-48c8-add7-a7f7fb13025a   5Gi        RWX            Delete           Failed   test/pvc-azurefile   azurefile               3m13s

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/azurefile-csi-driver#500

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix Azure file share not deleted issue when the namespace is deleted

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix Azure file share not deleted issue when the namespace is deleted

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2020
@andyzhangx andyzhangx mentioned this pull request Dec 21, 2020
Closed
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/assign @ZeroMagic

ZeroMagic
ZeroMagic approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@ZeroMagic ZeroMagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2490a79 into kubernetes:master Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 21, 2020
This was referenced Dec 22, 2020
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jan 5, 2021
Open
k8s-ci-robot added a commit that referenced this pull request Jan 6, 2021
@k8s-ci-robot
Merge pull request #97449 from andyzhangx/automated-cherry-pick-of-#9…
aedab82 
…7417-upstream-release-1.20

Automated cherry pick of #97417: fix azure file secret not found issue
k8s-ci-robot added a commit that referenced this pull request Jan 6, 2021
@k8s-ci-robot
Merge pull request #97453 from andyzhangx/automated-cherry-pick-of-#9…
ff7724e 
…7417-upstream-release-1.18

Automated cherry pick of #97417: fix azure file secret not found issue
k8s-ci-robot added a commit that referenced this pull request Jan 6, 2021
@k8s-ci-robot
Merge pull request #97450 from andyzhangx/automated-cherry-pick-of-#9…
49b1bd0 
…7417-upstream-release-1.19

Automated cherry pick of #97417: fix azure file secret not found issue
@andyzhangx andyzhangx mentioned this pull request Feb 10, 2021
Closed
@liggitt liggitt mentioned this pull request Feb 14, 2021
Closed
@liggitt liggitt mentioned this pull request Mar 18, 2021
Merged
andyzhangx added a commit to andyzhangx/kubernetes that referenced this pull request Mar 19, 2021
@andyzhangx
Revert "Automated cherry pick of kubernetes#97417: fix azure file sec…
3ddf61d 
…ret not found issue"
andyzhangx added a commit to andyzhangx/kubernetes that referenced this pull request Mar 19, 2021
@andyzhangx
Revert "Automated cherry pick of kubernetes#97417: fix azure file sec…
7266a38 
…ret not found issue"
andyzhangx added a commit to andyzhangx/kubernetes that referenced this pull request Mar 19, 2021
@andyzhangx
Revert "Automated cherry pick of kubernetes#97417: fix azure file sec…
9f3bf75 
…ret not found issue"
@msau42 msau42 mentioned this pull request Mar 25, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 25, 2021
@k8s-ci-robot
Merge pull request #100563 from msau42/revert-azure
01f7495 
Revert #97417 "fix azure file secret not found issue"
k8s-ci-robot added a commit that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request #100398 from andyzhangx/revert-97450-automated-che…
5f2edef 
…rry-pick-of-#97417-upstream-release-1.19

Revert "Automated cherry pick of #97417: fix azure file secret not found issue"
k8s-ci-robot added a commit that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request #100397 from andyzhangx/revert-97453-automated-che…
a39c389 
…rry-pick-of-#97417-upstream-release-1.18

Revert "Automated cherry pick of #97417: fix azure file secret not found issue"
k8s-ci-robot added a commit that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request #100399 from andyzhangx/revert-97449-automated-che…
edc823e 
…rry-pick-of-#97417-upstream-release-1.20

Revert "Automated cherry pick of #97417: fix azure file secret not found issue"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroMagic ZeroMagic ZeroMagic approved these changes

@karataliu karataliu Awaiting requested review from karataliu

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@ZeroMagic ZeroMagic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Azure file share is not deleted when the namespace is deleted
3 participants
@andyzhangx @k8s-ci-robot @ZeroMagic