merge error check to validateEndpointsPorts

[JornShen]

/kind cleanup

I found after calling the validateEndpointsPorts, tests will do the same judge(use framework.ExpectNoError).
Merge this check to validateEndpointsPorts to make it more clear.

NONE

[k8s-ci-robot]

@JornShen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JornShen]

/cc @aojea

[aojea]

I´m not thrilled with these changes, last time that someone has changed one function in the opposite order, from failing to return err, we were running tests without checks during several months and nobody noticed ... the e2e framework grew organically and there are a lot of places and dependencies that are hard to detect

I'm sorry but I rather prefer to keep things the way they are unless we see a clear improvements ... the risk is too high and I can't see a big return

[JornShen]

It a private func and only used in service.go and conntrack.go file&nbsp

[aojea]

It a private func and only used in service.go and conntrack.go file  发自我的iPhone

yeah, I understand the goal and the intention, and appreciate it ... but I can't see that the returned value is enough, also this will complicate possible backports later

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JornShen, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/network/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.