Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: upgrading cAdvisor to 0.38.8 #99207

Merged
merged 2 commits into from Mar 13, 2021
Merged

vendor: upgrading cAdvisor to 0.38.8 #99207

merged 2 commits into from Mar 13, 2021

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Feb 18, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR upgrades cAdvisor 0.38.8 that fixes two bugs:

Which issue(s) this PR fixes:

Fixes #98870

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a regression in 1.19+ that caused cAdvisor to incorrectly detect single-socket multi-NUMA topology.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @iwankgb!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @iwankgb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2021
@k8s-ci-robot k8s-ci-robot requested review from dchen1107, thockin and a team February 18, 2021 17:05
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 18, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2021
@dims
Copy link
Member

dims commented Feb 18, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2021
@dims
Copy link
Member

dims commented Feb 18, 2021

/ok-to-test

@dims
Copy link
Member

dims commented Feb 18, 2021

/ok-to-test

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 18, 2021

/retest

1 similar comment
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 18, 2021

/retest

@ehashman ehashman added this to Triage in SIG Node PR Triage Feb 19, 2021
ehashman
ehashman reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 19, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Feb 19, 2021
@iwankgb iwankgb mentioned this pull request Feb 22, 2021
Merged
@hanamantagoudvk
Copy link

@ehashman @smarterclayton @thockin @dchen1107 @dims : Kindly request your approvals for this PR. I hope this makes to 1.20.5 patch release.

@iwankgb iwankgb mentioned this pull request Feb 23, 2021
Merged
thockin
thockin reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
This was referenced Feb 26, 2021
Merged
Merged
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 2, 2021
hasheddan
hasheddan approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hasheddan, iwankgb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 12, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@bobbypage
Copy link
Member

/retest

2 similar comments
@bobbypage
Copy link
Member

/retest

@bobbypage
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3090d5b into kubernetes:release-1.20 Mar 13, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@thockin thockin thockin left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@hasheddan hasheddan hasheddan approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@bobbypage bobbypage

@BenTheElder BenTheElder

@smarterclayton smarterclayton

@ehashman ehashman

@thockin thockin

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet