Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kubelet/cm/container logs to structured logging #100001

Merged
merged 3 commits into from Mar 16, 2021

Conversation

shiyajuan123
Copy link
Contributor

@shiyajuan123 shiyajuan123 commented Mar 9, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/cm/container_manager_linux.go and pkg/kubelet/cm/container_manager_stub.go to structured logging

Which issue(s) this PR fixes:

Ref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/M cncf-cla: yes do-not-merge/needs-sig needs-triage labels Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

Hi @shiyajuan123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test needs-priority labels Mar 9, 2021
@shiyajuan123
Copy link
Contributor Author

@shiyajuan123 shiyajuan123 commented Mar 9, 2021

/cc @yuzhiquan

@k8s-ci-robot k8s-ci-robot requested a review from yuzhiquan Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node and removed do-not-merge/needs-sig labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim and mrunalp Mar 9, 2021
@@ -675,7 +675,7 @@ func (cm *containerManagerImpl) Start(node *v1.Node,
for _, cont := range cm.systemContainers {
if cont.ensureStateFunc != nil {
if err := cont.ensureStateFunc(cont.manager); err != nil {
klog.Warningf("[ContainerManager] Failed to ensure state of %q: %v", cont.name, err)
klog.InfoS("[ContainerManager] Failed to ensure state of", "ensureState", cont.name, "err", err)
Copy link
Member

@yuzhiquan yuzhiquan Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log in err != nil statement, and with err arguments, may be ErrorS more available.

Copy link
Member

@ehashman ehashman Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning -> Info unless we fail (which we don't here)

Copy link
Contributor Author

@shiyajuan123 shiyajuan123 Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate it,please?

Copy link
Member

@yuzhiquan yuzhiquan Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning -> Info unless we fail (which we don't here)

@ehashman klog doesn't have WarningS, and as ubernetes/enhancements#1602 (comment), InfoS is ok here?

@yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Mar 9, 2021

/triage accepted
/priority backlog
/sig instrumentation

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@yuzhiquan: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/triage accepted
/release-note-none
/priority backlog
/sig instrumentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted priority/backlog sig/instrumentation and removed needs-triage needs-priority labels Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@yuzhiquan: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ehashman ehashman left a comment

/ok-to-test
/remove-priority backlog
/priority important-soon

pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/container_manager_linux.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/important-soon ok-to-test and removed needs-ok-to-test priority/backlog labels Mar 9, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 9, 2021
@shiyajuan123
Copy link
Contributor Author

@shiyajuan123 shiyajuan123 commented Mar 10, 2021

/test pull-kubernetes-integration

@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Mar 11, 2021
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Went through outstanding comments and verified all requested changes were made.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 11, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@shiyajuan123
Copy link
Contributor Author

@shiyajuan123 shiyajuan123 commented Mar 12, 2021

/assign @ConnorDoyle

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, shiyajuan123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 38fbecf into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

8 participants