Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename apiserver_storage_object_counts to apiserver_storage_objects #100082

Merged
merged 1 commit into from Mar 12, 2021

Conversation

logicalhan
Copy link
Contributor

@logicalhan logicalhan commented Mar 10, 2021

To conform to instrumentation best practices.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Pluralized _counts is actually an anti-pattern for metrics, instead we pluralize the name of the thing being counted for gauges.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`apiserver_storage_objects` (a newer version of `etcd_object_counts) is promoted and marked as stable. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1209-metrics-stability

…apiserver_storage_objects)

Change-Id: I8c08a37cd3ed7c943a6691185f750e55d389dd3a
@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/XS cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority approved area/apiserver area/test sig/api-machinery sig/instrumentation sig/testing and removed do-not-merge/needs-sig labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from dashpole and timothysc Mar 10, 2021
@logicalhan
Copy link
Contributor Author

@logicalhan logicalhan commented Mar 10, 2021

/sig instrumentation
/cc @erain
/triage accepted
/priority important-soon
/milestone v1.21

@k8s-ci-robot k8s-ci-robot requested a review from erain Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted priority/important-soon labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@k8s-ci-robot k8s-ci-robot removed needs-triage needs-priority labels Mar 10, 2021
@brancz
Copy link
Member

@brancz brancz commented Mar 10, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 10, 2021
@logicalhan
Copy link
Contributor Author

@logicalhan logicalhan commented Mar 10, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold label Mar 10, 2021
@logicalhan
Copy link
Contributor Author

@logicalhan logicalhan commented Mar 10, 2021

/retest

erain
erain approved these changes Mar 10, 2021
Copy link
Contributor

@erain erain left a comment

LGTM, and thanks!!

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, erain, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 10, 2021

Are we just waiting on the exception request approval to remove the hold?

@logicalhan
Copy link
Contributor Author

@logicalhan logicalhan commented Mar 10, 2021

Are we just waiting on the exception request approval to remove the hold?

yes.

@palnabarun
Copy link
Member

@palnabarun palnabarun commented Mar 11, 2021

/milestone v1.21

Putting back the milestone since the exception request was APPROVED. ref: https://groups.google.com/g/kubernetes-sig-release/c/p9E6s14269M/m/f0L7VhbeAgAJ

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold label Mar 11, 2021
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Mar 11, 2021

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 019c892 into kubernetes:master Mar 12, 2021
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apiserver area/test cncf-cla: yes kind/cleanup lgtm priority/important-soon release-note sig/api-machinery sig/instrumentation sig/testing size/XS triage/accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants