Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EndpointSlice controllers to avoid duplicate creations #100103

Merged
merged 1 commit into from Mar 11, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 10, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This updates the StaleSlices() method in EndpointSliceTracker to also ensure that the tracker does not have more slices than have been provided.

Which issue(s) this PR fixes:

Fixes #100033

Special notes for your reviewer:

This is a simpler replacement for #100042 after @lavalamp made it clear that we could depend on reliably getting deletes in onEndpointSliceDelete. I had previously thought that some deletes might get missed by these handlers.

Does this PR introduce a user-facing change?

EndpointSlice controllers are less likely to create duplicate EndpointSlices.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @aojea @lavalamp @swetharepakula @wojtek-t
/assign @freehan
/sig network
/priority important-soon

This updates the StaleSlices() method in EndpointSliceTracker to also
ensure that the tracker does not have more slices than have been
provided.

Co-Authored-By: Swetha Repakula <srepakula@google.com>
@k8s-ci-robot k8s-ci-robot added release-note kind/bug sig/network labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from aojea Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added size/L priority/important-soon labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 10, 2021

@robscott: GitHub didn't allow me to request PR reviews from the following users: swetharepakula.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This updates the StaleSlices() method in EndpointSliceTracker to also ensure that the tracker does not have more slices than have been provided.

Which issue(s) this PR fixes:

Fixes #100033

Special notes for your reviewer:

This is a simpler replacement for #100042 after @lavalamp made it clear that we could depend on reliably getting deletes in onEndpointSliceDelete. I had previously thought that some deletes might get missed by these handlers.

Does this PR introduce a user-facing change?

EndpointSlice controllers are less likely to create duplicate EndpointSlices.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @aojea @lavalamp @swetharepakula @wojtek-t
/assign @freehan
/sig network
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 10, 2021

@robscott: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved sig/apps labels Mar 10, 2021
@aojea
Copy link
Member

@aojea aojea commented Mar 10, 2021

@swetharepakula you should apply to the kubernetes org membership
https://github.com/kubernetes/community/blob/master/github-management/new-membership-procedure.md
lgtm

Copy link
Member

@freehan freehan left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, robscott, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link
Member

@annajung annajung commented Mar 11, 2021

/milestone v1.21

bug fix improves test coverage of existing code that was merged in before code freeze

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
robscott added a commit to robscott/kubernetes that referenced this issue Mar 11, 2021
This PR was filed as a temporary workaround to reduce flakiness. Now
that the root cause has been fixed by kubernetes#100103 we can restore the full
test.
@k8s-ci-robot k8s-ci-robot merged commit e2cdf0e into kubernetes:master Mar 11, 2021
14 checks passed
wawa0210 pushed a commit to wawa0210/kubernetes that referenced this issue Mar 12, 2021
This PR was filed as a temporary workaround to reduce flakiness. Now
that the root cause has been fixed by kubernetes#100103 we can restore the full
test.
@liggitt
Copy link
Member

@liggitt liggitt commented May 6, 2021

This fixed a flaky test added in 1.21 which was picked to 1.19 and 1.20. Should this fix also be picked to 1.19 and 1.20?

k8s-ci-robot added a commit that referenced this issue May 6, 2021
…3-upstream-release-1.20

Automated cherry pick of #100103: Updating EndpointSlice controllers to avoid duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes kind/bug lgtm needs-triage priority/important-soon release-note sig/apps sig/network size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants