Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/kubeletconfig to structured logging #100265

Merged
merged 1 commit into from Mar 16, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Mar 15, 2021

Remove plg/kubelet/kubeletconfig/util/log

Co-authored-by: Elana Hashman ehashman@redhat.com

What type of PR is this?

/kind cleanup

/priority important-soon
/milestone v1.21
/sig node

What this PR does / why we need it:

Structured log updates.

Which issue(s) this PR fixes:

See #98976

Special notes for your reviewer:

I picked up from #100010 which has stalled for a few days, as our extension deadline for merging all structured log changes is soon.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/1602

@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup priority/important-soon size/L labels Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/node cncf-cla: yes needs-triage area/kubelet labels Mar 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from odinuge and yujuhong Mar 15, 2021
@kikisdeliveryservice kikisdeliveryservice added the triage/accepted label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage label Mar 15, 2021
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

missed 2 :)

pkg/kubelet/kubeletconfig/controller.go Outdated Show resolved Hide resolved
pkg/kubelet/kubeletconfig/watch.go Outdated Show resolved Hide resolved
@kikisdeliveryservice kikisdeliveryservice moved this from Needs Reviewer to Waiting on Author in Structured Logging Migration for Kubelet, 1.21 Mar 15, 2021
Remove plg/kubelet/kubeletconfig/util/log

Co-authored-by: Elana Hashman <ehashman@redhat.com>
@kikisdeliveryservice
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Mar 15, 2021

/lgtm

@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 15, 2021
@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Mar 15, 2021
@yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-conformance-kind-ga-only-parallel

@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 16, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 045b5dd into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm priority/important-soon release-note-none sig/node size/L triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

6 participants