Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote SizeMemoryBackedVolumes to beta #100319

Merged

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Mar 16, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promotes existing Alpha feature to Beta.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

EmptyDir memory backed volumes are sized as the the minimum of pod allocatable memory on a host and an optional explicit user provided value.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/pull/2345

@k8s-ci-robot k8s-ci-robot added release-note kind/feature size/XS cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority approved labels Mar 16, 2021
@derekwaynecarr
Copy link
Member Author

@derekwaynecarr derekwaynecarr commented Mar 16, 2021

E2E testing was already defined and had coverage here:
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/storage/empty_dir.go#L298

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 16, 2021

/sig node
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/node priority/important-soon triage/accepted and removed do-not-merge/needs-sig needs-priority needs-triage labels Mar 16, 2021
@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Mar 16, 2021
@dims
Copy link
Member

@dims dims commented Mar 16, 2021

/retitle Promote SizeMemoryBackedVolumes to beta

@k8s-ci-robot k8s-ci-robot changed the title Promote SizeMemoryBackedVolumeSizing to beta Promote SizeMemoryBackedVolumes to beta Mar 16, 2021
@dims
Copy link
Member

@dims dims commented Mar 16, 2021

/retest

zouyee
zouyee approved these changes Mar 17, 2021
@dims
Copy link
Member

@dims dims commented Mar 17, 2021

/approve
/lgtm
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dims, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Member Author

@derekwaynecarr derekwaynecarr commented Mar 17, 2021

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit 2f8a225 into kubernetes:master Mar 17, 2021
15 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 17, 2021
@derekwaynecarr
Copy link
Member Author

@derekwaynecarr derekwaynecarr commented Mar 17, 2021

@dims I had an exception open and did not intend for this to merge prior to hearing a response https://groups.google.com/g/kubernetes-sig-node/c/7w1vqksOqHY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes kind/feature lgtm priority/important-soon release-note sig/node size/XS triage/accepted
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants