Add ability to skip OpenAPI handler installation #100341
Thinking about Anotine's feedback about not wanting to store a bool another idea I have is to require consumers to set the
Then, the handler installation is triggered by the spec being non-nil rather than the config. Instead of calling
The end result is that GenericAPIServer's
This seems like a better approach in terms of decoupling the
Okay, I just spoke to @apelisse and we decided to continue with the boolean approach. My suggestion about requiring consumers to pass the spec could introduce a big foot-gun where the spec doesn't match the config and so we'd probably need to generate the spec anyways to check for that.
Other ideas like passing a function in the config to optionally convert to a spec seemed like overkill compared to the bool, so we've agreed on that for now. Thoughts? PTAL @liggitt
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing