Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed kubectl describe ingress causing SEGFAULT if API Group is not specified #100505

Merged
merged 1 commit into from Mar 24, 2021

Conversation

lauchokyip
Copy link
Member

@lauchokyip lauchokyip commented Mar 23, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

When using kubectl describe ingress on this YAML file, it causes SEGFAULT

cat <<EOF | kubectl apply -f -
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test
spec:
  rules:
  - host: example.com
    http:
      paths:
      - pathType: Prefix
        path: /
        backend:
          resource:
            kind: PersistentVolumeClaim
            name: TestClaim
EOF

kubectl describe ing test

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1030

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl: Fixed panic when describing an ingress backend without an API Group

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none kind/bug size/M cncf-cla: yes do-not-merge/needs-sig needs-triage labels Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 23, 2021

Hi @lauchokyip. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test labels Mar 23, 2021
@lauchokyip lauchokyip closed this Mar 23, 2021
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli and removed do-not-merge/needs-sig labels Mar 23, 2021
@lauchokyip lauchokyip reopened this Mar 23, 2021
@lauchokyip
Copy link
Member Author

@lauchokyip lauchokyip commented Mar 23, 2021

/cc @rikatz

@k8s-ci-robot k8s-ci-robot requested a review from rikatz Mar 23, 2021
@rikatz
Copy link
Contributor

@rikatz rikatz commented Mar 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Mar 23, 2021
Copy link
Contributor

@soltysh soltysh left a comment

/triage accepted
/priority backlog
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted priority/backlog and removed needs-triage labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lauchokyip, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 24, 2021
@eddiezane
Copy link
Member

@eddiezane eddiezane commented Mar 24, 2021

@kubernetes/release-team-leads @palnabarun for approval since this fixes a nil-pointer

I'll also open cherrypicks

@soltysh
Copy link
Contributor

@soltysh soltysh commented Mar 24, 2021

Adding this to 1.21 since this is fixing a nil-pointer problem.
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit e71e284 into kubernetes:master Mar 24, 2021
13 of 14 checks passed
@eddiezane
Copy link
Member

@eddiezane eddiezane commented Mar 24, 2021

@lauchokyip can you please edit your top level comment and add the following release note?

kubectl: Fixed panic when describing an ingress backend without an API Group

@k8s-ci-robot k8s-ci-robot added release-note and removed release-note-none labels Mar 24, 2021
@soltysh
Copy link
Contributor

@soltysh soltysh commented Mar 24, 2021

@eddiezane fixed 😉

@lauchokyip
Copy link
Member Author

@lauchokyip lauchokyip commented Mar 24, 2021

Thank you @soltysh and @eddiezane !

@lauchokyip lauchokyip deleted the fixDescribe branch Mar 24, 2021
k8s-ci-robot added a commit that referenced this issue Mar 25, 2021
…00505-upstream-release-1.19

Automated cherry pick of #100505: Fixed describe ingress causing SEGFAULT
k8s-ci-robot added a commit that referenced this issue Mar 25, 2021
…00505-upstream-release-1.20

Automated cherry pick of #100505: Fixed describe ingress causing SEGFAULT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubectl cncf-cla: yes kind/bug lgtm ok-to-test priority/backlog release-note sig/cli size/M triage/accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants