Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #97417 "fix azure file secret not found issue" #100563

Merged
merged 1 commit into from Mar 25, 2021

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Mar 25, 2021

This reverts commit 8d43976.

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

The original #97417 change broke inline volumes.

Which issue(s) this PR fixes:

Addresses #99061

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Reverts breaking change to inline AzureFile volumes; referenced secrets are now searched for in the same namespace as the pod as in previous releases.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


This reverts commit 8d43976.

Change-Id: Iefaa0e76489883830ba1c9bdcbc3101bcc33082c
@k8s-ci-robot k8s-ci-robot added release-note kind/bug size/XS kind/regression cncf-cla: yes do-not-merge/needs-sig labels Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 25, 2021

@msau42: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage needs-priority labels Mar 25, 2021
@msau42
Copy link
Member Author

@msau42 msau42 commented Mar 25, 2021

/sig storage
/priority critical-urgent

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 25, 2021
@msau42
Copy link
Member Author

@msau42 msau42 commented Mar 25, 2021

/assign @feiskyer @gnufied
cc @liggitt

@k8s-ci-robot k8s-ci-robot added sig/storage priority/critical-urgent and removed do-not-merge/needs-sig labels Mar 25, 2021
@liggitt
Copy link
Member

@liggitt liggitt commented Mar 25, 2021

/lgtm

does this also require adjustment to the change made in https://github.com/kubernetes/kubernetes/pull/97877/files#r596900593 ?

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 25, 2021
@liggitt
Copy link
Member

@liggitt liggitt commented Mar 25, 2021

/kind regression
/milestone v1.21

undoes a 1.21 regression added in #97417

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 25, 2021
@msau42
Copy link
Member Author

@msau42 msau42 commented Mar 25, 2021

does this also require adjustment to the change made in https://github.com/kubernetes/kubernetes/pull/97877/files#r596900593 ?

Yes several followups need to be made after this revert:

I think those 2 followups are not as urgent (impacts new functionality vs existing functionality) so I'll let @andyzhangx followup in a future patch release.

@msau42
Copy link
Member Author

@msau42 msau42 commented Mar 25, 2021

/retest

1 similar comment
@msau42
Copy link
Member Author

@msau42 msau42 commented Mar 25, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 25, 2021

@msau42: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-file 9c169a2 link /test pull-kubernetes-e2e-aks-engine-azure-file
pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim 9c169a2 link /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes kind/bug kind/regression lgtm needs-priority needs-triage priority/critical-urgent release-blocker release-note sig/storage size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants