Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoundServiceAccountTokenVolume ga #101992

Merged
merged 1 commit into from
May 25, 2021
Merged

BoundServiceAccountTokenVolume ga #101992

merged 1 commit into from
May 25, 2021

Conversation

zshihang
Copy link
Contributor

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

graduate BoundServiceAccountTokenVolume to GA

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#542

Special notes for your reviewer:

Does this PR introduce a user-facing change?

BoundServiceAccountTokenVolume is GA. The feature gate is going to be removed in 1.23.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1205-bound-service-account-tokens

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2021
@zshihang
Copy link
Contributor Author

/triage accepted
/priority important-soon
/milestone 1.22
/cc @liggitt

@k8s-ci-robot
Copy link
Contributor

@zshihang: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/triage accepted
/priority important-soon
/milestone 1.22
/cc @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from liggitt May 13, 2021 22:11
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 13, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

liggitt
liggitt reviewed May 14, 2021
View reviewed changes
plugin/pkg/admission/serviceaccount/admission_test.go

admit := NewServiceAccount()
admit.generateName = testGenerateName
admit.boundServiceAccountTokenVolume = deprecationEnabledBoundTokenVolume
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is strange... was this testing admission with bound service account tokens turned on, and expecting a non-bound-service-account-token volume?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... no... it's testing what happens if a pod that has a secret-based volume already passes through admission. I think we want to keep this test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially i thought it was testing getReferencedServiceAccountToken then this test is not needed any more.

as you mentioned, bound token was actually enabled in this test. looks like it just made sure existing volume at DefaultAPITokenMountPath would prevent bound token volume mounting, which is duplicate of TestRespectsExistingMount.

@liggitt
Copy link
Member

liggitt commented May 14, 2021

/remove-kind api-change
/retest

lgtm, one question about the upgrade test

@k8s-ci-robot k8s-ci-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 14, 2021
@liggitt
Copy link
Member

liggitt commented May 14, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@liggitt liggitt self-assigned this May 17, 2021
@pacoxu
Copy link
Member

pacoxu commented May 25, 2021

/test pull-kubernetes-e2e-gce-alpha-features

@liggitt
Copy link
Member

liggitt commented May 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2021
@zshihang
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 548f16d into kubernetes:master May 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 25, 2021
@github-actions github-actions bot mentioned this pull request May 26, 2021
Open
@reylejano reylejano mentioned this pull request Jun 21, 2021
Closed
@dudicoco
Copy link

@zshihang @liggitt while testing this feature I have noticed that the service account secret object is still being created, is this behavior correct?

@liggitt
Copy link
Member

liggitt commented Sep 12, 2021

Yes. Removal of those secrets is distinct from this feature and the plan is being worked out in kubernetes/enhancements#2800

@dudicoco
Copy link

thanks @liggitt

@ALNBAND ALNBAND mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

TokenRequest API and Kubelet integration
6 participants
@zshihang @k8s-ci-robot @fejta-bot @liggitt @pacoxu @dudicoco