Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated validEgressSelectorNames 'master' #102242

Merged
merged 3 commits into from Sep 16, 2021

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented May 24, 2021

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Follow up of #95235
/cc andrewsykim

Special notes for your reviewer:

#94900 test related is still not done: only part one #100181

Does this PR introduce a user-facing change?

Remove 'master' as a valid EgressSelection type in the EgressSelectorConfiguration API.
@fejta-bot
Copy link

@fejta-bot fejta-bot commented May 24, 2021

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

Loading

@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from 0d643a0 to 6ff75d5 May 25, 2021
@pacoxu
Copy link
Member Author

@pacoxu pacoxu commented May 25, 2021

/cc cheftako

Loading

@k8s-ci-robot k8s-ci-robot requested a review from cheftako May 25, 2021
@fedebongio
Copy link
Contributor

@fedebongio fedebongio commented May 25, 2021

/assign @cheftako @caesarxuchao @Jefftree
/triage accepted

Loading

@pacoxu
Copy link
Member Author

@pacoxu pacoxu commented Jun 2, 2021

/priority important-soon
since it is targeting 1.22

Loading

@pacoxu
Copy link
Member Author

@pacoxu pacoxu commented Jun 3, 2021

I believe https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L938 and https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L956 will need to be updated as well.

@Jefftree Forget to change gce scripts: cluster/gce/gci/configure-helper.sh. Thanks.
Updated.

Loading

@pacoxu pacoxu force-pushed the controlplane-egress-selector branch 2 times, most recently from e7c325c to c39a5b6 Sep 15, 2021
@@ -527,7 +527,7 @@ func TestValidateEgressSelectorConfiguration(t *testing.T) {
},
},
{
Name: "master",
Name: "controlplane",
Copy link
Member Author

@pacoxu pacoxu Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dup test case.

Loading

Copy link
Member Author

@pacoxu pacoxu Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate error is like
Calling ValidateEgressSelectorConfiguration expected error, got [service.connection[1]: Duplicate value: "controlplane"]--- PASS: TestValidateEgressSelectorConfiguration (0.00s)

Loading

@pacoxu pacoxu requested a review from liggitt Sep 15, 2021
@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from c39a5b6 to 6ab02e0 Sep 15, 2021
@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from 6ab02e0 to 8e226f9 Sep 15, 2021
@pacoxu pacoxu marked this pull request as draft Sep 15, 2021
@pacoxu pacoxu marked this pull request as ready for review Sep 15, 2021
@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from 8e226f9 to 0db40ff Sep 15, 2021
pacoxu added 2 commits Sep 15, 2021
Signed-off-by: pacoxu <paco.xu@daocloud.io>
…ontrolplane'

Signed-off-by: pacoxu <paco.xu@daocloud.io>
@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from 0db40ff to f6d9d2a Sep 15, 2021
@pacoxu
Copy link
Member Author

@pacoxu pacoxu commented Sep 15, 2021

/retest
fix the verify failure for code generating.

Loading

@pacoxu pacoxu force-pushed the controlplane-egress-selector branch from f6d9d2a to c0b2c3f Sep 16, 2021
@liggitt
Copy link
Member

@liggitt liggitt commented Sep 16, 2021

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@liggitt liggitt added this to API review completed, 1.23 in API Reviews Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit a48a2ef into kubernetes:master Sep 16, 2021
14 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 16, 2021
ibabou added a commit to ibabou/kubernetes that referenced this issue Sep 28, 2021
* remove deprecated validEgressSelectorNames 'master'

Signed-off-by: pacoxu <paco.xu@daocloud.io>

* update gce configure: replace deprecated egress name 'master' with 'controlplane'

Signed-off-by: pacoxu <paco.xu@daocloud.io>

* add dup error for EgressSelection & fix converting alpha/beta to v1 name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment