Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NoExecute toleration for konnectivity agent #102592

Merged
merged 1 commit into from Sep 15, 2021
Merged

add NoExecute toleration for konnectivity agent #102592

merged 1 commit into from Sep 15, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jun 4, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #102582

Special notes for your reviewer:

Following node-local-dns and kube-proxy:

kubernetes/cluster/gce/addons/konnectivity-agent/konnectivity-agent-ds.yaml

Lines 21 to 24 in 646acf0

priorityClassName: system-cluster-critical
tolerations:
- key: "CriticalAddonsOnly"
operator: "Exists"

kubernetes/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml

Lines 132 to 138 in ea07644

tolerations:
- key: "CriticalAddonsOnly"
operator: "Exists"
- effect: "NoExecute"
operator: "Exists"
- effect: "NoSchedule"
operator: "Exists"

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 4, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jun 9, 2021

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-e2e-gce-network-proxy-http-connect

1 similar comment
@pacoxu
Copy link
Member Author

pacoxu commented Jun 9, 2021

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-e2e-gce-network-proxy-http-connect

@pacoxu pacoxu closed this Jun 23, 2021
@pacoxu pacoxu deleted the patch-11 branch June 23, 2021 06:10
@pacoxu pacoxu restored the patch-11 branch June 25, 2021 01:24
@pacoxu pacoxu reopened this Jun 25, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jun 25, 2021

/assign @bowei

@pacoxu
Copy link
Member Author

pacoxu commented Jun 28, 2021

I cannot figure out the failure of pull-kubernetes-e2e-gce-network-proxy-http-connect
/skip

/assign @cheftako

@jkh52
Copy link
Contributor

jkh52 commented Jul 7, 2021

I don't believe these test (flakes?) could be related to this change (run agent with more tolerations).

/retest

@jkh52
Copy link
Contributor

jkh52 commented Jul 8, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jkh52: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Member Author

pacoxu commented Sep 14, 2021

/triage accepted
kindly ping @cheftako

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Sep 15, 2021

/test pull-kubernetes-e2e-gce-network-proxy-http-connect

@k8s-ci-robot k8s-ci-robot merged commit 03e0106 into kubernetes:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@amwat amwat mentioned this pull request Sep 16, 2021
Closed
@pacoxu pacoxu mentioned this pull request Sep 17, 2021
Merged
@pacoxu pacoxu deleted the patch-11 branch May 10, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@bowei bowei

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Konnectivity Service doesn't tolerate wildcard taints and gets evicted when node gets tainted with NoExecute.
5 participants
@pacoxu @jkh52 @k8s-ci-robot @cheftako @bowei