Allow write on events to edit role

[tumido]

What type of PR is this?

/kind bug
/sig auth

What this PR does / why we need it:

Events are namespaced resources, however currently users with namespace admin/edit cluster role can only view this resource. This becomes a problem if they want to deploy any workload that is expecting to generate new events since even namespace admin can't grant write permissions to events.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

This issue was discussed in this Slack thread.

Does this PR introduce a user-facing change?

Aggregate write permissions on events to edit and admin role

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[k8s-ci-robot]

Hi @tumido. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enj]

/triage accepted
/ok-to-test
/assign @smarterclayton

I vaguely recall Clayton having some opinions on this in the last discussion that was years ago.

[smarterclayton]

Editors and admins in a namespace having write of events seems reasonable. An editor can already impact running applications (by deleting pods), and now that we have audit an admin doesn't have to rely on events to know what is happening to pods. I am in favor of allowing mutation of events for namespace mutation roles.

[enj]

/lgtm
/assign @deads2k

[deads2k]

I also find this reasonable. We didn't do this before because in the first versions of kube it was rare to have custom controllers.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• plugin/pkg/auth/authorizer/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment