Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated flag --experimental-bootstrap-kubeconfig #103172

Merged
merged 1 commit into from Sep 21, 2021

Conversation

@niulechuan
Copy link
Contributor

@niulechuan niulechuan commented Jun 25, 2021

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

The kubelet flag --experimental-bootstrap-kubeconfig had deprecatd for 3 years. we should remove that.

Which issue(s) this PR fixes:

xref #61680

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

The deprecated --experimental-bootstrap-kubeconfig flag has been removed.
This can be set via --bootstrap-kubeconfig.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None
Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 25, 2021

Hi @niulechuan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Jun 25, 2021

/ok-to-test
/triage accepted
/priority backlog
/lgtm
/assign @klueska

Loading

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, niulechuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit fed612c into kubernetes:master Sep 21, 2021
14 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment