Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert granting EndpointSlice write access to edit role #103703

Merged
merged 1 commit into from Jul 15, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Jul 14, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This reverts part of the change introduced by #101203 as a partial mitigation to #103675.

Does this PR introduce a user-facing change?

Aggregated roles no longer include write access to EndpointSlices. This rolls back part of a change that was introduced earlier in the Kubernetes 1.22 cycle.

/sig network
/cc @cjcullen
/assign @thockin @liggitt

This reverts part of the change introduced by kubernetes#101203.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from cjcullen Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2021
@robscott
Copy link
Member Author

robscott commented Jul 14, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2021
@liggitt
Copy link
Member

liggitt commented Jul 14, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2021
@thockin
Copy link
Member

thockin commented Jul 15, 2021

OK, since it has not yet released. IF we can find a good way to bring this back, I'll buy the keg :)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member Author

robscott commented Jul 15, 2021

/retest

@justaugustus
Copy link
Member

justaugustus commented Jul 15, 2021

/milestone v1.22
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1626352939150400?thread_ts=1626352939.150400&cid=C2C40FMNF

/retest

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 15, 2021
@enj enj added this to Needs Triage in SIG Auth Jul 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7fd021b into kubernetes:master Jul 15, 2021
14 checks passed
SIG Auth automation moved this from Needs Triage to Closed / Done Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Closed / Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants