Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SupportPodPidsLimit and SupportNodePidsLimit feature gates #104163

Merged
merged 1 commit into from Sep 20, 2021

Conversation

@ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Aug 5, 2021

/kind cleanup
/sig node
/priority backlog

Does this PR introduce a user-facing change?

The `SupportPodPidsLimit` and  `SupportNodePidsLimit` feature gates that are GA since v1.20 are unconditionally enabled, and can no longer be specified via the `--feature-gates` argument.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/757
- [Usage]: https://kubernetes.io/docs/concepts/policy/pid-limiting/
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 5, 2021

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Aug 5, 2021

Loading

Copy link
Member

@neolit123 neolit123 left a comment

could you please link in the OP to any tracking issues in kubernetes/kubernetes or kubernetes/enhancements.

/ok-to-test

Loading

@ehashman
Copy link
Member

@ehashman ehashman commented Aug 6, 2021

/triage accepted

please add related KEPs to original comment and I'll review

Loading

@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Aug 6, 2021
@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Aug 7, 2021

please add related KEPs to original comment and I'll review

Done.

Loading

@ialidzhikov ialidzhikov requested a review from neolit123 Aug 10, 2021
Copy link
Member

@neolit123 neolit123 left a comment

/lgtm
as per the timeline of the FGs.

Loading

@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Aug 13, 2021

ping @ehashman
for approval

Loading

@pacoxu pacoxu moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Aug 17, 2021
@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Aug 24, 2021

Loading

@RobertKrawitz
Copy link
Contributor

@RobertKrawitz RobertKrawitz commented Aug 24, 2021

ping @dims @derekwaynecarr @RobertKrawitz
for approval

I'm no longer involved in this area so my approval should not be required.

Loading

Copy link
Contributor

@RobertKrawitz RobertKrawitz left a comment

Pro forma approval, as I'm no longer involved in this area.

Loading

@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Sep 1, 2021

👀

Loading

@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Sep 11, 2021

/cc @ehashman

Loading

@k8s-ci-robot k8s-ci-robot requested a review from ehashman Sep 11, 2021
@neolit123
Copy link
Member

@neolit123 neolit123 commented Sep 13, 2021

/milestone v1.23
/unassign

Loading

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 13, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 13, 2021
@pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 17, 2021

/assign derekwaynecarr dchen1107
for approval from sig node feature approvers

Loading

Copy link
Member

@ehashman ehashman left a comment

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, ialidzhikov, mrunalp, RobertKrawitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit e8653fe into kubernetes:master Sep 20, 2021
15 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment