Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the BoundServiceAccountTokenVolume feature gate #104167

Conversation

@ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Aug 5, 2021

/kind cleanup
/sig auth
/priority backlog

Does this PR introduce a user-facing change?

The `BoundServiceAccountTokenVolume` feature gate that is GA since v1.22 is unconditionally enabled, and can no longer be specified via the `--feature-gates` argument.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 5, 2021

@ialidzhikov: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 5, 2021

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Aug 5, 2021

Loading

@enj enj added this to Needs Triage in SIG Auth Aug 9, 2021
@ialidzhikov ialidzhikov force-pushed the cleanup/boundserviceaccounttokenvolume branch from eb8d956 to bcd0c3b Aug 10, 2021
@pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 16, 2021

Should we remove this from test description [Feature:BoundServiceAccountTokenVolume] as it is removed?

var _ = SIGDescribe("ServiceAccount admission controller migration [Feature:BoundServiceAccountTokenVolume]", func() {

Not quite sure.

Loading

@ialidzhikov ialidzhikov changed the title Remove the BoundServiceAccountTokenVolume feature gates Remove the BoundServiceAccountTokenVolume feature gate Aug 18, 2021
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Contributor Author

@ialidzhikov ialidzhikov commented Sep 21, 2021

/test pull-kubernetes-unit

Loading

@liggitt
Copy link
Member

@liggitt liggitt commented Sep 21, 2021

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 9ff99ad into kubernetes:master Sep 21, 2021
15 checks passed
Loading
SIG Auth automation moved this from Needs Triage to Closed / Done Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment