legacy-cloud-providers: aws: Add support for consuming web identity credentials #104314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig cloud-provider |
k8s-ci-robot
added
sig/cloud-provider
This was referenced Aug 11, 2021
|
/area provider/aws |
|
/assign @nckturner |
k8s-ci-robot
added
the
lgtm
|
/assign |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
@cheftako agreed, I'd call it a bug fix because not being able to use the "web identity" JWTs in the credential chain is unintended and hampers certain use cases like using bound service account tokens for authentication to AWS when using the legacy provider in KCM. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 10, 2021
…4314-upstream-release-1.21 Automated cherry pick of #104314: legacy-cloud-providers: aws: Add support for consuming web
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 10, 2021
…4314-upstream-release-1.22 Automated cherry pick of #104314: legacy-cloud-providers: aws: Add support for consuming web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The in-tree AWS cloud provider currently uses a custom credential chain that does not support using service account tokens to authenticate with the AWS API. Namely the
WebIdentityTokenProvider.This is a pick from the external v1 AWS provider in kubernetes/cloud-provider-aws#238
I am aware that the in-tree legacy cloud providers are not looking to make changes at this point but I wanted to have a discussion about it.
Does this PR introduce a user-facing change?