Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix init container oomkilled as a failure #104650

Merged
merged 6 commits into from Nov 16, 2021
Merged

fix init container oomkilled as a failure #104650

merged 6 commits into from Nov 16, 2021

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Aug 29, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix initcontainer oomkiil as a failure

Which issue(s) this PR fixes:

Fixes: #104454

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Pod will not start when Init container was OOM killed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Aug 29, 2021

/sig node

@matthyx
Copy link
Contributor

matthyx commented Aug 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2021
@matthyx
Copy link
Contributor

matthyx commented Aug 30, 2021

I think it makes sense...
/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2021
@249043822 249043822 added this to Needs Reviewer in SIG Node PR Triage Aug 31, 2021
@aojea
Copy link
Member

aojea commented Aug 31, 2021

/assign @matthyx @SergeyKanzhelev

@matthyx
Copy link
Contributor

matthyx commented Sep 2, 2021

I leave it in the needs reviewer column to let others have a look.
/lgtm

@mrunalp mrunalp moved this from Needs Approver to Waiting on Author in SIG Node PR Triage Sep 13, 2021
@yxxhero
fix typo
5ba76eb 
Signed-off-by: yxxhero <aiopsclub@163.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@yxxhero
fix typo
20b3cd5 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Sep 14, 2021

@mrunalp Please review. Thanks very much.

@yxxhero
fix typo
c1b94d2 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Sep 21, 2021

@mrunalp ping

@pacoxu pacoxu moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Sep 26, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Oct 4, 2021

@mrunalp any update? Thanks very much.

@yxxhero
Copy link
Member Author

yxxhero commented Oct 10, 2021

@mrunalp ping

@yxxhero
Copy link
Member Author

yxxhero commented Oct 15, 2021

@mrunalp anything should I do? Thanks very much.

@yxxhero
Copy link
Member Author

yxxhero commented Nov 2, 2021

any update?

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/release-note-edit release-note Pod will not start when Init container was OOM killed.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@SergeyKanzhelev
Copy link
Member

/assign @mrunalp

@SergeyKanzhelev
Copy link
Member

/release-note-edit release-note Pod will not start when Init container was OOM killed.

Please update the release note, I think prow cannot do it as the initial message didn't have the release-note

@yxxhero
Copy link
Member Author

yxxhero commented Nov 3, 2021

/release-note-edit release-note Pod will not start when Init container was OOM killed.

Please update the release note, I think prow cannot do it as the initial message didn't have the release-note

done. Thanks very much. @SergeyKanzhelev

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Nov 4, 2021
@yxxhero yxxhero mentioned this pull request Nov 13, 2021
Closed
7 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Nov 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4638027 into kubernetes:master Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 16, 2021
@EladProject EladProject mentioned this pull request Mar 21, 2023
Open
@ruiwen-zhao ruiwen-zhao mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@matthyx matthyx Awaiting requested review from matthyx

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

@aojea aojea Awaiting requested review from aojea

@249043822 249043822 Awaiting requested review from 249043822

Assignees

@mrunalp mrunalp

@aojea aojea

@SergeyKanzhelev SergeyKanzhelev

@249043822 249043822

@matthyx matthyx

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Container marked OOMKilled when a non init process gets killed
9 participants
@yxxhero @k8s-ci-robot @matthyx @aojea @yangjunmyfm192085 @249043822 @s-kawamura-w664 @SergeyKanzhelev @mrunalp