Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on CSIMigrationAzureDisk by default on 1.23 #104670

Merged
merged 1 commit into from Sep 16, 2021

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 31, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

turn on CSIMigrationAzureDisk by default on 1.23

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

Does this PR introduce a user-facing change?

turn on CSIMigrationAzureDisk by default on 1.23

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

turn on CSIMigrationAzureDisk by default on 1.23
@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Aug 31, 2021

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

Loading

@Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Sep 5, 2021

I think we might need to migrate the CI to cloud-provider-azure or install the azuredisk csi driver by default.

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 5, 2021

I think we might need to migrate the CI to cloud-provider-azure or install the azuredisk csi driver by default.

@Jiawei0227 yes, I will fix it later

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 6, 2021

one related PR: kubernetes/test-infra#23487

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 6, 2021

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 6, 2021

/test pull-kubernetes-e2e-capz-azure-file

Loading

1 similar comment
@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 6, 2021

/test pull-kubernetes-e2e-capz-azure-file

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 6, 2021

/test pull-kubernetes-e2e-capz-azure-disk

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 7, 2021

/test pull-kubernetes-e2e-capz-azure-file

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 7, 2021

/test pull-kubernetes-e2e-capz-azure-disk

Loading

@Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Sep 7, 2021

/retest

Loading

@Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Sep 7, 2021

/lgtm

Loading

@Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Sep 7, 2021

Seems on windows side it still need some setting?

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 8, 2021

Seems on windows side it still need some setting?

@Jiawei0227 that's windows test issue, I am still fixing it, need more time.

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 8, 2021

/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

Loading

2 similar comments
@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

Loading

@andyzhangx andyzhangx changed the title [WIP]turn on CSIMigrationAzureDisk by default on 1.23 turn on CSIMigrationAzureDisk by default on 1.23 Sep 13, 2021
@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

finally, I have fixed all tests with csi driver enabled, could you approve? thanks.
@smarterclayton

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/test pull-kubernetes-e2e-capz-azure-file-vmss

Loading

@andyzhangx
Copy link
Member Author

@andyzhangx andyzhangx commented Sep 13, 2021

/retest

Loading

@Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Sep 13, 2021

@msau42 for approval.
cc @jsafrane @xing-yang

Loading

@jsafrane
Copy link
Member

@jsafrane jsafrane commented Sep 16, 2021

/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 5d7ac70 into kubernetes:master Sep 16, 2021
21 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants