Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move IPv6DualStack feature to stable. #104691

Merged
merged 15 commits into from Sep 24, 2021
Merged

Conversation

@khenidak
Copy link
Contributor

@khenidak khenidak commented Aug 31, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

moves dual-stack feature to stable by removing conditional checks against feature flags and modify the code as needed.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

We have an interesting problem in kube-proxy init logic where it does not fail if it does not find iptables support for IPv6. And it does not check if iptables support is enabled even for IPv6 single cluster. I have a couple of ideas around this. will include later in the same PR. I left a note in the code.

Does this PR introduce a user-facing change?

IPv6DualStack feature moved to stable.
Controller Manager flags for the node IPAM controller have slightly changed:
1. When configuring a dual-stack cluster, the user must specify both --node-cidr-mask-size-ipv4 and --node-cidr-mask-size-ipv6 to set the per-node IP mask sizes, instead of the previous --node-cidr-mask-size flag.
2. The --node-cidr-mask-size flag is mutually exclusive with --node-cidr-mask-size-ipv4 and --node-cidr-mask-size-ipv6.
3. Single-stack clusters do not need to change, but may choose to use the more specific flags.  Users can use either the older --node-cidr-mask-size flag or one of the newer --node-cidr-mask-size-ipv4 or --node-cidr-mask-size-ipv6 flags to configure the per-node IP mask size, provided that the flag's IP family matches the cluster's IP family (--cluster-cidr).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/563-dual-stack
https://github.com/kubernetes/enhancements/pull/2860#pullrequestreview-733375378
@bridgetkromhout
Copy link

@bridgetkromhout bridgetkromhout commented Aug 31, 2021

Enhancement issue: kubernetes/enhancements#563

Loading

@khenidak
Copy link
Contributor Author

@khenidak khenidak commented Aug 31, 2021

/assign @thockin
/assign @aojea

Loading

@khenidak khenidak force-pushed the dualstack-stable branch from ed32ad6 to f63f814 Sep 24, 2021
Copy link
Member

@thockin thockin left a comment

Thanks!

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit a53e2ea into kubernetes:master Sep 24, 2021
16 checks passed
Loading
SIG Node CI/Test Board automation moved this from PRs Waiting on Author to Done Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
SIG Auth automation moved this from Needs Triage to Closed / Done Sep 24, 2021
@fedebongio
Copy link
Contributor

@fedebongio fedebongio commented Sep 28, 2021

/triage accepted

Loading

ibabou added a commit to ibabou/kubernetes that referenced this issue Sep 28, 2021
* kube-proxy

* endpoints controller

* app: kube-controller-manager

* app: cloud-controller-manager

* kubelet

* app: api-server

* node utils + registry/strategy

* api: validation (comment removal)

* api:pod strategy (util pkg)

* api: docs

* core: integration testing

* kubeadm: change feature gate to GA

* service registry and rest stack

* move feature to GA

* generated
aojea added a commit to aojea/kubernetes that referenced this issue Nov 5, 2021
* kube-proxy

* endpoints controller

* app: kube-controller-manager

* app: cloud-controller-manager

* kubelet

* app: api-server

* node utils + registry/strategy

* api: validation (comment removal)

* api:pod strategy (util pkg)

* api: docs

* core: integration testing

* kubeadm: change feature gate to GA

* service registry and rest stack

* move feature to GA

* generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment