Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-controller-manager: properly check generic ephemeral volume feature #104913

Merged

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented Sep 10, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Due to a cut-and-paste error in the original implementation in Kubernetes 1.19,
support for generic ephemeral inline volumes in the PVC protection controller
was incorrectly tied to the "storage object in use" feature gate.

Special notes for your reviewer:

Found by @ikeeip when removing the StorageObjectInUseProtection feature gate (#104903 (comment)).

Does this PR introduce a user-facing change?

kube-controller incorrectly enabled support for generic ephemeral inline volumes if the storage object in use protection feature was enabled.
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19,
support for generic ephemeral inline volumes in the PVC protection controller
was incorrectly tied to the "storage object in use" feature gate.
@pohly
Copy link
Contributor Author

@pohly pohly commented Sep 10, 2021

/priority important-soon

Loading

@alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Sep 10, 2021

/lgtm
/assign @sttts

Loading

@fedebongio
Copy link
Contributor

@fedebongio fedebongio commented Sep 14, 2021

/cc @deads2k to take a look
/triage accepted

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 14, 2021

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: to, take, a, look.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @deads2k to take a look
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 14, 2021

/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 5e2ec0c into kubernetes:master Sep 14, 2021
14 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 14, 2021
k8s-ci-robot added a commit that referenced this issue Oct 6, 2021
…3-origin-release-1.20

Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
k8s-ci-robot added a commit that referenced this issue Oct 6, 2021
…3-origin-release-1.21

Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
k8s-ci-robot added a commit that referenced this issue Oct 14, 2021
…3-origin-release-1.22

Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants