mount-utils: force-format xfs-filesystems too #104923
Signed-off-by: David J. M. Karlsen firstname.lastname@example.org
What type of PR is this?
What this PR does / why we need it:
XFS filesystems are not force-formatted, this might lead to failures as initially experienced in openebs/lvm-localpv#135
Which issue(s) this PR fixes:
Should I maybe clone the issue into this repo?
Special notes for your reviewer:
See similar behaviour for ext3/4 filesystems.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
The text was updated successfully, but these errors were encountered:
@davidkarlsen: This issue is currently awaiting triage.
If a SIG or subproject determines this is a relevant issue, they will accept it by applying the
I'd like to make sure I understand this: Format shouldn't happen if there is no filesystem. What would cause this code path to be hit (i.e. no filesystem detected, but format fails because a filesystem exists)? I couldn't quite follow openebs/lvm-localpv#135
I checked the PR that introduced force for ext3/ext4 formatting (kubernetes/utils#127) and I didn't see a good explanation there either.
The code relies on underlying OS tooling which simply checks the volume for traces of file systems, and gives you a warning that you are about to overwrite a file system you possibly hold dear - "are you really sure...".
The default behavior of
This is fine in a manual environment, but with regards to automatically provisioning file systems this will only halt provisioning needlessly. You create and remove file systems all the time, so there will quickly be traces of old file systems.
When creating a logical volume, lvm will take what is marked as available. This is your security.
Then mkfs comes in and creates a file system.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing