Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cmd/proxy/{config, healthcheck, winkernel} to structured logging #104944

Merged
merged 3 commits into from Sep 20, 2021

Conversation

@jyz0309
Copy link
Member

@jyz0309 jyz0309 commented Sep 13, 2021

Signed-off-by: jyz0309 45495947@qq.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

related to #104872

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate `cmd/proxy/{config, healthcheck, winkernel}` to structured logging 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 13, 2021

@jyz0309: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 13, 2021

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@jyz0309
Copy link
Member Author

@jyz0309 jyz0309 commented Sep 13, 2021

/wg structured-logging
/area logging
/priority important-longterm
/cc @kubernetes/wg-structured-logging-reviews

Loading

@serathius
Copy link
Contributor

@serathius serathius commented Sep 13, 2021

Please don't write Fixes X as this will close the original Issue

Loading

pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
@jyz0309 jyz0309 requested a review from yangjunmyfm192085 Sep 14, 2021
@yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Sep 14, 2021

/ok-to-test

Loading

@mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Sep 16, 2021

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

Loading

@jyz0309
Copy link
Member Author

@jyz0309 jyz0309 commented Sep 16, 2021

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

I will squash all commits into 1 commit to solve it.

Loading

Signed-off-by: jyz0309 <45495947@qq.com>

remove useless str

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
Copy link
Member Author

@jyz0309 jyz0309 commented Sep 16, 2021

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

done. Please take a look again~

Loading

@jyz0309
Copy link
Member Author

@jyz0309 jyz0309 commented Sep 16, 2021

/retest-required

Loading

@serathius
Copy link
Contributor

@serathius serathius commented Sep 17, 2021

/cc @thockin

Loading

@k8s-ci-robot k8s-ci-robot requested a review from thockin Sep 17, 2021
@serathius serathius moved this from Waiting on Reviewer to Needs Approval in WG Structured Logging - 1.23 Migration Sep 17, 2021
@jyz0309
Copy link
Member Author

@jyz0309 jyz0309 commented Sep 20, 2021

/assign @thockin

Loading

pkg/proxy/config/config.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
Loading
jyz0309 added 2 commits Sep 20, 2021
Signed-off-by: jyz0309 <45495947@qq.com>
Signed-off-by: jyz0309 <45495947@qq.com>
Copy link
Member

@thockin thockin left a comment

Thanks!

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-triage-robot
Copy link

@k8s-triage-robot k8s-triage-robot commented Sep 20, 2021

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

Loading

@k8s-ci-robot k8s-ci-robot merged commit acbeaf8 into kubernetes:master Sep 20, 2021
14 checks passed
Loading
WG Structured Logging - 1.23 Migration automation moved this from Needs Approval to Done Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment