Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: remove the flag --port from scheduler manifest #105034

Merged
merged 1 commit into from Sep 15, 2021

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 15, 2021

/kind cleanup
Since #96345 was merged, kubeadm should remove --port=0.

Fixes kubernetes/kubeadm#2207

kubeadm: remove the --port flag from the manifest for the kube-scheduler since the flag has been a NO-OP since 1.23 and insecure serving was removed for the component.
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 15, 2021

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@pacoxu pacoxu changed the title Kubeadm insecure port kubeadm: remove the flag --port from scheduler manifest Sep 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from neolit123 and RA489 Sep 15, 2021
@neolit123
Copy link
Member

@neolit123 neolit123 commented Sep 15, 2021

Since #96345 was merged, kubeadm should remove --port=0.

I was watching that PR too.
For the other components we removed the flag one release later, but given it is a no-op it also makes sense to remove it in the same release.

The release note SGTM.

Loading

Copy link
Member

@neolit123 neolit123 left a comment

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 73d51a2 into kubernetes:master Sep 15, 2021
14 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment