Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated pkg/proxy/winuserspace to structured logging #105035

Merged
merged 3 commits into from Sep 16, 2021

Conversation

@shivanshu1333
Copy link
Member

@shivanshu1333 shivanshu1333 commented Sep 15, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/proxy/winuserspace to structured logging

Which issue(s) this PR fixes:

Fixes #
Ref #104872

Special notes for your reviewer:

Does this PR introduce a user-facing change?

migrated pkg/proxy/winuserspace to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 15, 2021

@shivanshu1333: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 15, 2021

Hi @shivanshu1333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@shivanshu1333
Copy link
Member Author

@shivanshu1333 shivanshu1333 commented Sep 15, 2021

/wg structured-logging
/area logging
/priority important-soon
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews

Loading

@shivanshu1333
Copy link
Member Author

@shivanshu1333 shivanshu1333 commented Sep 15, 2021

Note to reviewers: This PR is very similar to the merged PR #104931

Loading

@shivanshu1333
Copy link
Member Author

@shivanshu1333 shivanshu1333 commented Sep 15, 2021

/lint

Loading

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

@shivanshu1333: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

pkg/proxy/winuserspace/proxysocket.go Outdated Show resolved Hide resolved
Loading
pkg/proxy/winuserspace/proxysocket.go Outdated Show resolved Hide resolved
Loading
@shivanshu1333
Copy link
Member Author

@shivanshu1333 shivanshu1333 commented Sep 16, 2021

/retest

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 16, 2021

@shivanshu1333: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

Copy link
Member

@thockin thockin left a comment

Thanks!

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivanshu1333, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@shivanshu1333
Copy link
Member Author

@shivanshu1333 shivanshu1333 commented Sep 16, 2021

/label tide/merge-method-squash

Loading

@k8s-ci-robot k8s-ci-robot merged commit f06ce08 into kubernetes:master Sep 16, 2021
14 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 16, 2021
@shivanshu1333 shivanshu1333 deleted the pkg-proxy-winuserspace branch Sep 17, 2021
ibabou added a commit to ibabou/kubernetes that referenced this issue Sep 28, 2021
)

* migrated roundrobin.go

* migrated proxysocket.go

* used KRef in service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment