Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next step in CSI migration for openstack #107462

Merged
merged 1 commit into from Jan 13, 2022
Merged

Next step in CSI migration for openstack #107462

merged 1 commit into from Jan 13, 2022

Conversation

dims
Copy link
Member

@dims dims commented Jan 11, 2022 •
edited

Following up on #98538 that went into k8s v1.21

We remove usage of features.CSIMigrationOpenStack from the code base and set a timer to delete features.CSIMigrationOpenStack in 1.26.

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

OpenStack Cinder CSI migration is now GA and switched on by default, Cinder CSI driver must be installed on clusters on OpenStack for Cinder volumes to work (has been since v1.21).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2022
@dims
Copy link
Member Author

dims commented Jan 11, 2022

/assign @xing-yang @jsafrane @gnufied

@dims
Next step in CSI migration for openstack
7fd9743 
delete/modify tests that use intree cinder as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the next-step-in-csi-migration-for-openstack-take-2 branch from 6fefb16 to 7fd9743 Compare January 11, 2022 03:07
@dims dims mentioned this pull request Jan 11, 2022
Closed
@dims
Copy link
Member Author

dims commented Jan 11, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2022
@xing-yang
Copy link
Contributor

@dims Do you know if there's an enhancement issue for CSI migration for OpenStack? I couldn't find it.

@Jiawei0227
Copy link
Contributor

/retest

@Jiawei0227 Jiawei0227 mentioned this pull request Jan 11, 2022
Merged
@Jiawei0227
Copy link
Contributor

@dims Do you know if there's an enhancement issue for CSI migration for OpenStack? I couldn't find it.

PR for the KEP is here: kubernetes/enhancements#3124

If folks REALLY need the in-tree, they will now have to switch OFF features.InTreePluginOpenStackUnregister as with this PR we switch off the in-tree registration.

How will folks use in-tree if they turn off features.InTreePluginOpenStackUnregister?

@xing-yang
Copy link
Contributor

If folks REALLY need the in-tree, they will now have to switch OFF features.InTreePluginOpenStackUnregister as with this PR we switch off the in-tree registration.

How will folks use in-tree if they turn off features.InTreePluginOpenStackUnregister?

I think the change to features.InTreePluginOpenStackUnregister was in the earlier version of the PR but it is not in this latest version of the PR any more. @dims Can you please update the PR description to reflect this change?

@dims
Copy link
Member Author

dims commented Jan 11, 2022

@xing-yang Done!

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@dims
Copy link
Member Author

dims commented Jan 12, 2022

/hold cancel

thanks @xing-yang

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 42436c8 into kubernetes:master Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 13, 2022
This was referenced Feb 28, 2022
Closed
Closed
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Mar 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@gnufied gnufied

@xing-yang xing-yang

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @k8s-ci-robot @xing-yang @Jiawei0227 @k8s-triage-robot @gnufied @jsafrane