Skip to content

Conversation

@alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Apr 14, 2022

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Disable JobTrackingWithFinalizers due to unresolved bug

Which issue(s) this PR fixes:

Mitigates #109485

Special notes for your reviewer:

There are no E2E changes required, because they are independent of the feature.

Does this PR introduce a user-facing change?

Fix a 1.23 regression to set JobTrackingWithFinalizers, beta feature, as disabled by default, due to unresolved bug https://github.com/kubernetes/kubernetes/issues/109485

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 14, 2022
@alculquicondor
Copy link
Member Author

The failure looks like #109473

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2022
@alculquicondor
Copy link
Member Author

/sig apps
/area batch

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. area/batch labels Apr 14, 2022
@alculquicondor
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 14, 2022
@alculquicondor alculquicondor changed the title WIP Disable JobTrackingWithFinalizers due to unresolved bug Disable JobTrackingWithFinalizers due to unresolved bug Apr 14, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2022
Change-Id: Ieeeab689ae51dfe0dc06bdca88519d0ecf66d636
@liggitt
Copy link
Member

liggitt commented Apr 14, 2022

/lgtm
/approve
/milestone v1.24

This will be picked to release-1.23 to mitigate a regression in that release. If this isn't included in 1.24.0, we'd pick it to 1.24.1. I think it is clearer/cleaner to include in 1.24.0 (we're still in the window where regressions identified in release candidates would be fixed), but will defer to the release team.

/hold for release team ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2022
@cici37
Copy link
Contributor

cici37 commented Apr 14, 2022

Does doc need to be updated as well: content/en/docs/concepts/workloads/controllers/job.md ?
/cc @nate-double-u

@nate-double-u
Copy link

Does doc need to be updated as well: content/en/docs/concepts/workloads/controllers/job.md?

I think so, I've opened a k/website issue here: kubernetes/website#32944

Thanks for the heads up @cici37!

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
and 👍 for 1.24 inclusion from sig-apps pov

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Apr 15, 2022

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/batch area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants