Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate MinDomains in Pod Topology Spread to beta #110388

Merged
merged 3 commits into from Jul 18, 2022

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Jun 5, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduate MinDomains in Pod Topology Spread to beta

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3022

Special notes for your reviewer:

Does this PR introduce a user-facing change?

the `minDomains` field in Pod Topology Spread is graduated to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3022

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and ncdc Jun 5, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 5, 2022

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sanposhiho
Copy link
Member Author

sanposhiho commented Jun 14, 2022

Strange... I've run hack/update-openapi-spec.sh but not resolved...

@sanposhiho sanposhiho force-pushed the graduate-mindomain-beta branch from d38fed9 to 100fc06 Compare Jun 14, 2022
@sftim
Copy link
Contributor

sftim commented Jun 14, 2022

For the release note, could we call it minDomains or “the minDomains field”? Referring to the field using the case convention from the API is more relevant to end users.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@sanposhiho
Copy link
Member Author

sanposhiho commented Jun 15, 2022

@sftim 👍
Updated the release note.

@sanposhiho sanposhiho force-pushed the graduate-mindomain-beta branch from 100fc06 to 24e0279 Compare Jun 17, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
@sanposhiho sanposhiho force-pushed the graduate-mindomain-beta branch from 24e0279 to d1c611e Compare Jun 18, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2022
@sanposhiho sanposhiho force-pushed the graduate-mindomain-beta branch 2 times, most recently from 9212f6e to fa0915d Compare Jun 18, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2022
@sanposhiho
Copy link
Member Author

sanposhiho commented Jun 20, 2022

/assign @liggitt
/cc @alculquicondor

@liggitt
Do we currently have a problem with pull-kubernetes-verify or hack/update-openapi-spec.sh..?
I've run hack/update-openapi-spec.sh in this branch, but pull-kubernetes-verify still says Please run hack/update-openapi-spec.sh. (even after I rebase this branch with the latest master.)

What might be related to this issue is that, in latest master, running hack/update-openapi-spec.sh makes the following changes under api/open-spec/v3/.
sanposhiho#6
(IIUC, pull-kubernetes-verify confirms there is no diff between the result of hack/update-openapi-spec.sh and the code, and that means the code in master isn't caused any changes by running hack/update-openapi-spec.sh.)

@@ -5711,7 +5711,7 @@ type TopologySpreadConstraint struct {
// because computed skew will be 3(3 - 0) if new Pod is scheduled to any of the three zones,
// it will violate MaxSkew.
//
// This is an alpha field and requires enabling MinDomainsInPodTopologySpread feature gate.
// This is an beta field and requires enabling MinDomainsInPodTopologySpread feature gate.
Copy link
Member

@alculquicondor alculquicondor Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the field in the v1 package as well.

Copy link
Member Author

@sanposhiho sanposhiho Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 🙏

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2022
@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 9, 2022

/retest

1 similar comment
@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 10, 2022

/retest

@@ -3434,7 +3434,7 @@ type TopologySpreadConstraint struct {
// because computed skew will be 3(3 - 0) if new Pod is scheduled to any of the three zones,
// it will violate MaxSkew.
//
// This is an alpha field and requires enabling MinDomainsInPodTopologySpread feature gate.
// This is an beta field and requires enabling MinDomainsInPodTopologySpread feature gate.
Copy link
Member

@alculquicondor alculquicondor Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This is an beta field and requires enabling MinDomainsInPodTopologySpread feature gate.
// This is a beta field and requires the MinDomainsInPodTopologySpread feature gate to be enabled (enabled by default).

Copy link
Member Author

@sanposhiho sanposhiho Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@alculquicondor
Copy link
Member

alculquicondor commented Jul 11, 2022

/lgtm
/approve

@alculquicondor
Copy link
Member

alculquicondor commented Jul 11, 2022

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@leilajal
Copy link
Contributor

leilajal commented Jul 12, 2022

/cc @alexzielenski @Jefftree
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2022
@liggitt liggitt added this to In progress in API Reviews Jul 13, 2022
@ncdc
Copy link
Member

ncdc commented Jul 13, 2022

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc Jul 13, 2022
@liggitt
Copy link
Member

liggitt commented Jul 18, 2022

/lgtm
/approve

@liggitt liggitt moved this from In progress to API review completed, 1.25 in API Reviews Jul 18, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit bd1c9c1 into kubernetes:master Jul 18, 2022
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
API review completed, 1.25
Development

Successfully merging this pull request may close these issues.

None yet

8 participants