Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: respect user specified image repository when using Kubernetes ci version #111017

Merged
merged 1 commit into from Jul 11, 2022

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jul 8, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubeadm: respect user specified image repository when using Kubernetes ci version

Before this patch:

# kubeadm config images list --kubernetes-version=ci/latest-1.24
gcr.io/k8s-staging-ci-images/kube-apiserver:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-controller-manager:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-scheduler:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-proxy:v1.24.3-rc.0.29_99b7713ba36e8f
registry.k8s.io/pause:3.7
registry.k8s.io/etcd:3.5.4-0
registry.k8s.io/coredns/coredns:v1.9.3
# kubeadm config images list --kubernetes-version=ci/latest-1.24 --image-repository registry.cn-hangzhou.aliyuncs.com/google_containers
gcr.io/k8s-staging-ci-images/kube-apiserver:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-controller-manager:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-scheduler:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-proxy:v1.24.3-rc.0.29_99b7713ba36e8f
registry.cn-hangzhou.aliyuncs.com/google_containers/pause:3.7
registry.cn-hangzhou.aliyuncs.com/google_containers/etcd:3.5.4-0
registry.cn-hangzhou.aliyuncs.com/google_containers/coredns:v1.9.3

After this patch:

# kubeadm config images list --kubernetes-version=ci/latest-1.24
gcr.io/k8s-staging-ci-images/kube-apiserver:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-controller-manager:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-scheduler:v1.24.3-rc.0.29_99b7713ba36e8f
gcr.io/k8s-staging-ci-images/kube-proxy:v1.24.3-rc.0.29_99b7713ba36e8f
registry.k8s.io/pause:3.7
registry.k8s.io/etcd:3.5.4-0
registry.k8s.io/coredns/coredns:v1.9.3
# kubeadm config images list --kubernetes-version=ci/latest-1.24 --image-repository registry.cn-hangzhou.aliyuncs.com/google_containers
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-apiserver:v1.24.3-rc.0.29_99b7713ba36e8f
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-controller-manager:v1.24.3-rc.0.29_99b7713ba36e8f
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-scheduler:v1.24.3-rc.0.29_99b7713ba36e8f
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-proxy:v1.24.3-rc.0.29_99b7713ba36e8f
registry.cn-hangzhou.aliyuncs.com/google_containers/pause:3.7
registry.cn-hangzhou.aliyuncs.com/google_containers/etcd:3.5.4-0
registry.cn-hangzhou.aliyuncs.com/google_containers/coredns:v1.9.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: respect user specified image repository when using Kubernetes ci version

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 8, 2022

@SataQiu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 8, 2022
Copy link
Member

@neolit123 neolit123 left a comment

can we have some unit tests or is it too entangled?

/lgtm
/hold

remove hold if you'd like.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@SataQiu
Copy link
Member Author

SataQiu commented Jul 8, 2022

can we have some unit tests or is it too entangled?

/lgtm /hold

remove hold if you'd like.

will add some unit tests soon.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2022
@SataQiu
Copy link
Member Author

SataQiu commented Jul 9, 2022

/retest

pacoxu
pacoxu approved these changes Jul 11, 2022
Copy link
Member

@pacoxu pacoxu left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

neolit123 commented Jul 11, 2022

Can we remove the hold?

@SataQiu
Copy link
Member Author

SataQiu commented Jul 11, 2022

Can we remove the hold?

@neolit123
Sure!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 11, 2022

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 11, 2022

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 44e403f into kubernetes:master Jul 11, 2022
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants