Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the deprecated Measure method #111065

Merged
merged 1 commit into from Jul 13, 2022

Conversation

chendave
Copy link
Member

@chendave chendave commented Jul 11, 2022

As what suggested by Ginkgo migration guide, Measure node was
deprecated and replaced with It node which creates gmeasure.Experiment.

Signed-off-by: Dave Chen dave.chen@arm.com

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #109744

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ginkgo.Measure has been deprecated in Ginkgo V2, switch to use gomega/gmeasure instead

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig testing

As what suggested by Ginkgo migration guide, `Measure` node was
deprecated and replaced with `It` node which creates `gmeasure.Experiment`.

Signed-off-by: Dave Chen <dave.chen@arm.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2022

@chendave: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2022

@chendave: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Jul 11, 2022
@chendave
Copy link
Member Author

chendave commented Jul 11, 2022

/cc @pohly
/cc @aojea

This help us to get rid of one last warning on the deprecation.

@k8s-ci-robot k8s-ci-robot requested review from aojea and pohly Jul 11, 2022
@chendave
Copy link
Member Author

chendave commented Jul 12, 2022

/assign @aojea :)

@aojea
Copy link
Member

aojea commented Jul 12, 2022

it lgtm but it will be better if @onsi confirms is correct

/assign @liggitt

for vendor dependencies

@liggitt
Copy link
Member

liggitt commented Jul 12, 2022

/approve

for deps

deferring lgtm to @onsi ack

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@onsi
Copy link

onsi commented Jul 12, 2022

this looks good to me. not sure if there are any consumers downstream scraping the test output to record the result of the measurement... if so, those might need to change.

@aojea
Copy link
Member

aojea commented Jul 12, 2022

this looks good to me. not sure if there are any consumers downstream scraping the test output to record the result of the measurement... if so, those might need to change.

people should not rely on the test output 😈 , that contract doesn't exist AFAIK

/lgtm

Thanks onsi for taking the time on this

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@oomichi
Copy link
Member

oomichi commented Jul 12, 2022

/release-note-none

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 12, 2022

@oomichi: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chendave
Copy link
Member Author

chendave commented Jul 13, 2022

release-note-edit ginkgo.Measure has been deprecated in Ginkgo V2, switch to use gomega/gmeasure instead

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5d7fdf1 into kubernetes:master Jul 13, 2022
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 13, 2022
@chendave chendave deleted the cleanup_measure branch Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants