Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting UIDs tracking expectations #111721

Merged

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Aug 5, 2022

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fix the deletion of expectations that we no longer need. Without this fix, the job controller memory leaks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix memory leak in the job controller related to JobTrackingWithFinalizers

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2022

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Aug 5, 2022

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Aug 5, 2022

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 5, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Aug 5, 2022

This needs to be backported to 1.24 and 1.23 as well.

@dims
Copy link
Member

dims commented Aug 5, 2022

@alculquicondor needs milestone to be set for this to merge in master branch

Change-Id: I5dad644cf5cb232ebed0950a14b35a781a38eeb0
@alculquicondor
Copy link
Member Author

alculquicondor commented Aug 5, 2022

Would you mind adding it? I don't have permissions.

Copy link
Member

@janetkuo janetkuo left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@janetkuo janetkuo added this to the v1.25 milestone Aug 5, 2022
@janetkuo
Copy link
Member

janetkuo commented Aug 5, 2022

Added to 1.25 milestone.

@k8s-ci-robot k8s-ci-robot merged commit 1374391 into kubernetes:master Aug 5, 2022
13 of 14 checks passed
k8s-ci-robot added a commit that referenced this pull request Aug 9, 2022
…of-#111721-upstream-release-1.24

Automated cherry pick of #111721: Fix deleting UIDs tracking expectations
k8s-ci-robot added a commit that referenced this pull request Aug 9, 2022
…of-#111721-upstream-release-1.23

Automated cherry pick of #111721: Fix deleting UIDs tracking expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants