New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tests for job metrics by resetting them #113166
Simplify tests for job metrics by resetting them #113166
Conversation
@alculquicondor: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just call the function :)
if err != nil { | ||
t.Fatalf("Failed to collect the JobPodsFinished metric before creating the job: %q", err) | ||
} | ||
|
||
// create a single job and wait for its completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call the resetMetrics
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, it was passing locally because the cases use different labels
fe83228
to
b631e5d
Compare
/lgtm |
Change-Id: I20a0acbbb179bf895953b9d7af72625a2191b8eb
b631e5d
to
b8bd168
Compare
rebased |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority backlog |
/lgtm |
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
By resetting the metrics for each test, we don't need to query the old values.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: