[Prepare for go1.20] *: Bump versions and fix tests #114766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/cleanup
|
/test pull-kubernetes-unit-go-canary
|
k8s-ci-robot
added
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
|
hmm... check-dependency-stats thinks total dependencies increased by 4: {
- "directDependencies": 212,
- "transitiveDependencies": 234,
- "totalDependencies": 285,
+ "directDependencies": 213,
+ "transitiveDependencies": 238,
+ "totalDependencies": 289,
"maxDepthOfDependencies": 23
} |
|
/test pull-kubernetes-unit-go-canary |
k8s-ci-robot
added
approved
MadhavJivrajani
force-pushed
the
prepare-for-go1.20
branch
from
f5187d6
to
2974d48
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
Bumping version to include changes that better handle TLS errors. Bump nescessary to prepare for when the version of Go is bumped to 1.20 Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Modify unwrap error utility to make it work with go1.20 This version of Go introduces a new layer of wrapping via a new error type. The commit accounts for that while being compatible with go1.19 Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
MadhavJivrajani
force-pushed
the
prepare-for-go1.20
branch
from
2974d48
to
c31cc5e
Compare
k8s-ci-robot
added
sig/architecture
palnabarun
reviewed
Jan 12, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7603391429f359dfcd96b9e781a9574b21384b19
|
This was referenced Jan 12, 2023
k8s-ci-robot
added a commit
that referenced
this pull request
May 23, 2023
[1.26] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests
k8s-ci-robot
added a commit
that referenced
this pull request
May 23, 2023
[1.24] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests
k8s-ci-robot
added a commit
that referenced
this pull request
May 23, 2023
[1.25] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Commit 1:
Bumping version of govmomi to include changes that
better handle TLS errors. Bump nescessary
to prepare for when the version of Go is
bumped to 1.20.
Command run:
See #114502 (comment)
Commit 2:
This PR also adapts to this bump.
Commit 3:
This commit modifies the unwrap logic of tests for vclib connection tests to accommodate for new error types introduced in go1.20 and be backward compatible with go1.19
Which issue(s) this PR fixes:
Special notes for your reviewer:
On running the canary job for unit tests, theTestWithVerificationWithoutCaCertOrThumbprinttest will still fail. See #114502 (comment)Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority important-soon
/assign @liggitt @dims
(I messed up something in git because of which the previous PR closed, apologies!)