New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated pkg/scheduler/framework/plugins/noderesources
to contextual logging
#116748
Migrated pkg/scheduler/framework/plugins/noderesources
to contextual logging
#116748
Conversation
Skipping CI for Draft Pull Request. |
/test all |
/test pull-kubernetes-integration |
/test pull-kubernetes-node-e2e-containerd |
/triage accepted |
pkg/scheduler/framework/plugins/noderesources/resource_allocation.go
Outdated
Show resolved
Hide resolved
3cda06d
to
f28579e
Compare
pkg/scheduler/framework/plugins/noderesources/resource_allocation.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/framework/plugins/noderesources/balanced_allocation.go
Outdated
Show resolved
Hide resolved
f28579e
to
54e6f60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @mengjiao-liu
LGTM label has been added. Git tree hash: 9c86f9d6f38f334301acc6145ec4f24c58039c78
|
/assign @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mengjiao-liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Migrated
pkg/scheduler/framework/plugins/noderesources
to contextual loggingWhich issue(s) this PR fixes:
Part of #91633 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig instrumentation
/wg structured-logging
/area logging
/sig scheduling