feat: add ports autocompletion for kubectl port-forward command

[TessaIO]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR aims to add ports autocompletion for kubectl port-forward command

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1536

Special notes for your reviewer:

For now, it just outputs the port number. If you want to support also port names let me know.

Does this PR introduce a user-facing change?

Added ports autocompletion for kubectl port-foward command

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[TessaIO]

/retest

[gnufred]

I am able to test the new feature by:

• Compiling kubectl from this PR.
• Sourcing kubectl completion <shell>
• Creating an NGINX deployment
• Adding containerPort: 80 to the container specification
• Typing kubectl port-forward pods/nx1-********* <TAB> which causes 80 to appear.

https://github.com/kubernetes/kubectl/issues/1536 requested, to autocomplete local_port:remote_port, that being said, specifying a single port like 80 is interpreted as 80:80, which works just fine.

If I edit the deployment to configure port 8080, here's the result:

~ $ kubectl port-forward pods/nx1-84f54865b5-vjtrx <TAB>
~ $ kubectl port-forward pods/nx1-84f54865b5-vjtrx 8080
Forwarding from 127.0.0.1:8080 -> 8080
Forwarding from [::1]:8080 -> 8080

Looks good to me.

[TessaIO]

/retest

[gnufred]

/lgtm

Code has comments.
Code is clear/clean.
New functions are covered by tests.

[k8s-ci-robot]

@gnufred: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ardaguclu]

What is the difference between this PR and #122752?

[TessaIO]

What is the difference between this PR and #122752?

I don't get your point exactly, but it was open for quite some time and there's no activity there. Also, you can see that there are some differences in terms of implementation + I have some tests here

[ardaguclu]

What is the difference between this PR and #122752?

I don't get your point exactly, but it was open for quite some time and there's no activity there. Also, you can see that there are some differences in terms of implementation + I have some tests here

I think, in such cases it is better to notify the authors (e.g. #122752) that your PR is based on their code to prevent duplicate efforts and share the credits of the overall work.

[lucasrod16]

What is the difference between this PR and #122752?

I don't get your point exactly, but it was open for quite some time and there's no activity there. Also, you can see that there are some differences in terms of implementation + I have some tests here

I think, in such cases it is better to notify the authors (e.g. #122752) that your PR is based on their code to prevent duplicate efforts and share the credits of the overall work.

@ardaguclu I'm okay with @TessaIO taking over the implementation in this PR. I will close #122752 in favor of this PR. I appreciate it

[brianpursley]

Completion working as expected.

See comments about unit test.

[TessaIO]

@brianpursley @ah8ad3 @ardaguclu Tests added. Feel free to do another round of review.

[ah8ad3]

Thanks, LGTM

[ah8ad3]

/lgtm

/cc @ardaguclu @brianpursley for review and approve

[k8s-ci-robot]

@ah8ad3: GitHub didn't allow me to request PR reviews from the following users: for, review, and, approve.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/lgtm

/cc @ardaguclu @brianpursley for review and approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: e40e707393544dda6a0355b00fd8797ab4ac7bc7

[ardaguclu]

Actual code implementation looks good to me. Left a few comments for tests.

[ardaguclu]

@TessaIO thanks for spending time and effort on this PR.

LGTM

[ah8ad3]

Thanks for effort. /lgtm

[TessaIO]

/assign @brianpursley

[brianpursley]

/lgtm

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: cb9c46516a5b6112406a65026baf4bde9060c6c2

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ah8ad3, brianpursley, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [brianpursley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[brianpursley]

/remove-sig auth