kubelet: Surface description for predicate failed Events #125498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem:** When a Pod fails to run due to kubelet-side admission checks, the
v1.Event objects emitted looks like these:
Reason="NodeAffinity" Message="Predicate NodeAffinity failed"
Reason="NodeName" Message="Predicate NodeName failed"
Reason="NodePorts" Message="Predicate NodePorts failed"
**Solution:** Expose human-readable predicate description in the failure
so that kubelet submits an Event with this description, such as:
Reason="NodeAffinity" Message="Predicate NodeAffinity failed: node(s) didn't match Pod's node affinity/selector"
Reason="NodeName" Message="Predicate NodeName failed: node(s) didn't match the requested node name"
Reason="NodePorts" Message="Predicate NodePorts failed: node(s) didn't have free ports for the requested pod ports"
k8s-ci-robot
added
release-note-none
Contributor
|
/triage accepted /assign @mrunalp |
k8s-ci-robot
added
the
triage/accepted
k8s-ci-robot
added
lgtm
Contributor
|
LGTM label has been added. Git tree hash: fde9535f5c81974b7dd6171932e729f9fd85307b
|
mrunalp
approved these changes
Jul 1, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@ahmetb "kubelet does admission checks after a pod that's scheduled" . Do we have any doc to explain this concept? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/sig node
What this PR does / why we need it:
Problem:
When a Pod fails to start due to kubelet-side admission checks, kubelet reports
v1/Eventfor the Pod using the following event payload format:This is not super helpful, to especially to beginners who do not know that kubelet does admission checks after a pod that's scheduled and ran on the host before. It's also unclear the what the names of predicates refer to.
Solution:
Expose human-readable predicate description in the failure so that kubelet submits an
Eventwith this description, such as:Which issue(s) this PR fixes:
N/A - have not opened an issue since it's a small change that seems rather inconsequential.
Special notes for your reviewer:
Tested with a new kubelet build from HEAD in
kind, and triggering the predicate failures listed above.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: