Skip to content

PortForward over Websockets Graduates to Beta #125528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 16, 2024
Merged

PortForward over Websockets Graduates to Beta #125528

k8s-ci-robot merged 1 commit into from
Jun 16, 2024

Conversation

@seans3
Copy link
Contributor

@seans3 seans3 commented Jun 15, 2024

  • PortForward using WebSockets instead of SPDY graduates to Beta
    • PortForwardWebsockets server-side feature gate is now on by default
    • kubectl now initially attempts to stream using Websockets by default, falling back to SPDY if the initial upgrade fails. Setting PORT_FORWARD_WEBSOCKETS environment variable to false will turn off this functionality.

/kind feature

- Feature gates for PortForward (kubectl port-forward) over WebSockets are now enabled by default (Beta).
  - Server-side feature gate: PortForwardWebsocket
  - Client-side (kubectl) feature gate: PORT_FORWARD_WEBSOCKETS environment variable
  - To turn off PortForward over WebSockets for kubectl, the environment variable feature gate must be explicitly set - PORT_FORWARD_WEBSOCKETS=false

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from liggitt June 15, 2024 23:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 15, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jun 15, 2024

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 15, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jun 15, 2024

/assign @aojea

@seans3
Copy link
Contributor Author

seans3 commented Jun 15, 2024

/cc @jpbetz

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz June 15, 2024 23:19
seans3
seans3 commented Jun 15, 2024
View reviewed changes
pkg/features/kube_features.go

// owner: @seans3
// kep: http://kep.k8s.io/4006
// alpha: v1.29
Copy link
Contributor Author

@seans3 seans3 Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally removed this in previous PR.

seans3
seans3 commented Jun 15, 2024
View reviewed changes
staging/src/k8s.io/client-go/tools/portforward/fallback_dialer.go
)

var _ httpstream.Dialer = &fallbackDialer{}
var _ httpstream.Dialer = &FallbackDialer{}
Copy link
Contributor Author

@seans3 seans3 Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting this structure now in order to make it testable elsewhere.

@aojea
Copy link
Member

aojea commented Jun 16, 2024

/lgtm
/approve
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2024

LGTM label has been added.

Git tree hash: 19f638a68743101dd409b80cdf36cb38ab014e3b

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef9965e into kubernetes:master Jun 16, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 16, 2024
@seans3 seans3 mentioned this pull request Jun 16, 2024
Open
12 tasks
@seans3
Copy link
Contributor Author

seans3 commented Jun 16, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2024
@chrischdi chrischdi mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@liggitt liggitt Awaiting requested review from liggitt

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@liggitt liggitt

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG CLI
Archived in project

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

4 participants

@seans3 @aojea @k8s-ci-robot @liggitt