-
Notifications
You must be signed in to change notification settings - Fork 41.7k
KEP-3962: MutatingAdmissionPolicy Alpha #127134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/label api-review This needs additional tests but is otherwise feature complete and ready for API review. |
e898cdc to
0104d90
Compare
|
/triage accepted |
This expands the generic plugin support to both validating and mutating policies. It also adds the mutating policy admission plugin using the generics plugin support. This also implements both ApplyConfiguration and JSONPatch support. Co-authored-by: Alexander Zielensk <alexzielenski@gmail.com>
Co-authored-by: cici37 <cicih@google.com> Co-authored-by: Alexander Zielensk <alexzielenski@gmail.com>
Co-authored-by: Alexander Zielensk <alexzielenski@gmail.com>
Also apply reviewer feedback
|
/lgtm /assign @deads2k |
|
LGTM label has been added. Git tree hash: 59aabefafd6d980290490755f44ea9e39d30ff16
|
d02b47b to
0dc08ed
Compare
|
/retest Flake was: |
|
|
||
| genericfeatures.MutatingAdmissionPolicy: { | ||
| {Version: version.MustParse("1.30"), Default: false, PreRelease: featuregate.Alpha}, | ||
| {Version: version.MustParse("1.32"), Default: false, PreRelease: featuregate.Alpha}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaron-prindle fyi something like this could cause our feature gate test to fail with 1.32 emulating 1.31. We should special case scenarios where gates were introduced and then deferred to a following release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, the Compatility versions feature gate integration test that verifies gates are correct for n-1..3 versions (eg: binary @ 1.32 using --emulated-version=1.31 is in compliance with the feature gates from 1.31) already will work for this change as it is an alpha API and alpha APIs are allowed to be removed w.r.t to Compatibility versions
|
/approve |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, deads2k, jpbetz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements alpha of kubernetes/enhancements#3962
This supersedes #126497 to include:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Please use the following format for linking documentation: