Skip to content

release-1.32: pin system-validators to v1.9.2 #134090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

release-1.32: pin system-validators to v1.9.2 #134090

merged 1 commit into from
Sep 26, 2025

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 16, 2025 •
edited
Loading

What type of PR is this?

/kind bug

cherry-pick #134089 to v1.32 (as it use system-validators v1.9.1), bump it to v1.9.2

What this PR does / why we need it:

Which issue(s) this PR is related to:

xref kubernetes/system-validators#51

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump system-validators to v1.9.2: remove version-specific cgroup kernel config checks to avoid false failures on cgroup v2 systems when v1-only configs are missing.

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 16, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Sep 16, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Sep 17, 2025

/cc @neolit123
/sig cluster-lifecycle
/area kubeadm

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/kubeadm and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Sep 17, 2025

/test pull-kubernetes-integration

@neolit123 neolit123 mentioned this pull request Sep 17, 2025
Closed
neolit123
neolit123 reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

bump system validator to v1.9.2 to remove cgroup v1/v2 only checks

this needs a more detailed release note, because users usually are confused about these SV bumps.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2025

LGTM label has been added.

Git tree hash: fc982c8d0747acd75fc9d9e2e02153cf7527157d

@pacoxu pacoxu mentioned this pull request Sep 18, 2025
Merged
@pacoxu
Copy link
Member Author

pacoxu commented Sep 19, 2025

/assign @dims

soltysh
soltysh approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Sep 19, 2025

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 19, 2025 09:46
@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu, saschagrunert, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a2e7a01 into kubernetes:release-1.32 Sep 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@logicalhan logicalhan Awaiting requested review from logicalhan

+1 more reviewer

@neolit123 neolit123 neolit123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@neolit123 neolit123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubeadm cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

6 participants

@pacoxu @k8s-ci-robot @neolit123 @soltysh @saschagrunert @dims